Add real-time logging to service stop command

- Update stop command to use background systemctl with immediate log following
- Use same approach as start command for consistent real-time log viewing
- Version bump to 0.1.84

CLAUDE.md

@@ -49,8 +49,12 @@ hostname2 = [
 ### Navigation
 - **Tab**: Switch between hosts
 - **↑↓ or j/k**: Select services
+- **s**: Start selected service (UserStart)
+- **S**: Stop selected service (UserStop)
 - **J**: Show service logs (journalctl)
 - **L**: Show custom log files
+- **R**: Rebuild current host
+- **B**: Run backup on current host
 - **q**: Quit dashboard
 
 ## Core Architecture Principles

Cargo.lock

@@ -270,7 +270,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"
 
 [[package]]
 name = "cm-dashboard"
-version = "0.1.72"
+version = "0.1.83"
 dependencies = [
  "anyhow",
  "chrono",
@@ -292,7 +292,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-agent"
-version = "0.1.72"
+version = "0.1.83"
 dependencies = [
  "anyhow",
  "async-trait",
@@ -315,7 +315,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-shared"
-version = "0.1.72"
+version = "0.1.83"
 dependencies = [
  "chrono",
  "serde",

README.md

@@ -88,7 +88,9 @@ cm-dashboard • ● cmbox ● srv01 ● srv02 ● steambox
 - **s**: Start selected service (UserStart)  
 - **S**: Stop selected service (UserStop)
 - **J**: Show service logs (journalctl in tmux popup)
+- **L**: Show custom log files (tail -f custom paths in tmux popup)
 - **R**: Rebuild current host
+- **B**: Run backup on current host
 - **q**: Quit
 
 ### Status Indicators
@@ -173,9 +175,10 @@ subscriber_ports = [6130]
 [hosts]
 predefined_hosts = ["cmbox", "srv01", "srv02"]
 
-[ui]
-ssh_user = "cm"
+[ssh]
+rebuild_user = "cm"
 rebuild_alias = "nixos-rebuild-cmtec"
+backup_alias = "cm-backup-run"
 ```
 
 ## Technical Implementation

agent/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-agent"
-version = "0.1.73"
+version = "0.1.84"
 edition = "2021"
 
 [dependencies]

agent/src/agent.rs

@@ -4,7 +4,7 @@ use std::time::Duration;
 use tokio::time::interval;
 use tracing::{debug, error, info};
 
-use crate::communication::{AgentCommand, ServiceAction, ZmqHandler};
+use crate::communication::{AgentCommand, ZmqHandler};
 use crate::config::AgentConfig;
 use crate::metrics::MetricCollectionManager;
 use crate::notifications::NotificationManager;
@@ -315,79 +315,10 @@ impl Agent {
                 info!("Processing Ping command - agent is alive");
                 // Could send a response back via ZMQ if needed
             }
-            AgentCommand::ServiceControl { service_name, action } => {
-                info!("Processing ServiceControl command: {} {:?}", service_name, action);
-                if let Err(e) = self.handle_service_control(&service_name, &action).await {
-                    error!("Failed to execute service control: {}", e);
-                }
-            }
         }
         Ok(())
     }
 
-    /// Handle systemd service control commands
-    async fn handle_service_control(&mut self, service_name: &str, action: &ServiceAction) -> Result<()> {
-        let (action_str, is_user_action) = match action {
-            ServiceAction::Start => ("start", false),
-            ServiceAction::Stop => ("stop", false), 
-            ServiceAction::Status => ("status", false),
-            ServiceAction::UserStart => ("start", true),
-            ServiceAction::UserStop => ("stop", true),
-        };
-
-        info!("Executing systemctl {} {} (user action: {})", action_str, service_name, is_user_action);
-
-        // Handle user-stopped service tracking before systemctl execution (stop only)
-        match action {
-            ServiceAction::UserStop => {
-                info!("Marking service '{}' as user-stopped", service_name);
-                if let Err(e) = self.service_tracker.mark_user_stopped(service_name) {
-                    error!("Failed to mark service as user-stopped: {}", e);
-                } else {
-                    // Sync to global tracker
-                    UserStoppedServiceTracker::update_global(&self.service_tracker);
-                }
-            }
-            _ => {}
-        }
-
-        // Spawn the systemctl command asynchronously to avoid blocking the agent
-        let service_name_clone = service_name.to_string();
-        let action_str_clone = action_str.to_string();
-        
-        tokio::spawn(async move {
-            let result = tokio::process::Command::new("sudo")
-                .arg("systemctl")
-                .arg(&action_str_clone)
-                .arg(format!("{}.service", service_name_clone))
-                .output()
-                .await;
-
-            match result {
-                Ok(output) => {
-                    if output.status.success() {
-                        info!("Service {} {} completed successfully", service_name_clone, action_str_clone);
-                        if !output.stdout.is_empty() {
-                            debug!("stdout: {}", String::from_utf8_lossy(&output.stdout));
-                        }
-                    } else {
-                        let stderr = String::from_utf8_lossy(&output.stderr);
-                        error!("Service {} {} failed: {}", service_name_clone, action_str_clone, stderr);
-                    }
-                }
-                Err(e) => {
-                    error!("Failed to execute systemctl {} {}: {}", action_str_clone, service_name_clone, e);
-                }
-            }
-        });
-
-        info!("Service {} {} command initiated (non-blocking)", service_name, action_str);
-
-        // Note: Service status will be updated by the normal metric collection cycle
-        // once the systemctl operation completes
-
-        Ok(())
-    }
 
     /// Check metrics for user-stopped services that are now active and clear their flags
     fn clear_user_stopped_flags_for_active_services(&mut self, metrics: &[Metric]) {

agent/src/collectors/backup.rs

@@ -136,6 +136,7 @@ impl Collector for BackupCollector {
             name: "backup_overall_status".to_string(),
             value: MetricValue::String(match overall_status {
                 Status::Ok => "ok".to_string(),
+                Status::Inactive => "inactive".to_string(),
                 Status::Pending => "pending".to_string(),
                 Status::Warning => "warning".to_string(),
                 Status::Critical => "critical".to_string(),
@@ -199,6 +200,7 @@ impl Collector for BackupCollector {
                 name: format!("backup_service_{}_status", service_name),
                 value: MetricValue::String(match service_status {
                     Status::Ok => "ok".to_string(),
+                    Status::Inactive => "inactive".to_string(),
                     Status::Pending => "pending".to_string(),
                     Status::Warning => "warning".to_string(),
                     Status::Critical => "critical".to_string(),

agent/src/collectors/systemd.rs

@@ -8,7 +8,6 @@ use tracing::debug;
 
 use super::{Collector, CollectorError};
 use crate::config::SystemdConfig;
-use crate::service_tracker::UserStoppedServiceTracker;
 
 /// Systemd collector for monitoring systemd services
 pub struct SystemdCollector {
@@ -357,33 +356,15 @@ impl SystemdCollector {
     /// Calculate service status, taking user-stopped services into account
     fn calculate_service_status(&self, service_name: &str, active_status: &str) -> Status {
         match active_status.to_lowercase().as_str() {
-            "active" => {
-                // If service is now active and was marked as user-stopped, clear the flag
-                if UserStoppedServiceTracker::is_service_user_stopped(service_name) {
-                    debug!("Service '{}' is now active - clearing user-stopped flag", service_name);
-                    // Note: We can't directly clear here because this is a read-only context
-                    // The agent will need to handle this differently
-                }
-                Status::Ok
-            },
+            "active" => Status::Ok,
             "inactive" | "dead" => {
-                // Check if this service was stopped by user action
-                if UserStoppedServiceTracker::is_service_user_stopped(service_name) {
-                    debug!("Service '{}' is inactive but marked as user-stopped - treating as OK", service_name);
-                    Status::Ok
-                } else {
-                    Status::Warning
-                }
+                debug!("Service '{}' is inactive - treating as Inactive status", service_name);
+                Status::Inactive
             },
             "failed" | "error" => Status::Critical,
             "activating" | "deactivating" | "reloading" | "start" | "stop" | "restart" => {
-                // For user-stopped services that are transitioning, keep them as OK during transition
-                if UserStoppedServiceTracker::is_service_user_stopped(service_name) {
-                    debug!("Service '{}' is transitioning but was user-stopped - treating as OK", service_name);
-                    Status::Ok
-                } else {
-                    Status::Pending
-                }
+                debug!("Service '{}' is transitioning - treating as Pending", service_name);
+                Status::Pending
             },
             _ => Status::Unknown,
         }

agent/src/communication/mod.rs

@@ -98,19 +98,4 @@ pub enum AgentCommand {
     ToggleCollector { name: String, enabled: bool },
     /// Request status/health check
     Ping,
-    /// Control systemd service
-    ServiceControl {
-        service_name: String,
-        action: ServiceAction,
-    },
-}
-
-/// Service control actions
-#[derive(Debug, Clone, serde::Deserialize, serde::Serialize)]
-pub enum ServiceAction {
-    Start,
-    Stop,
-    Status,
-    UserStart,  // User-initiated start (clears user-stopped flag)
-    UserStop,   // User-initiated stop (marks as user-stopped)
 }

agent/src/service_tracker.rs

@@ -90,14 +90,6 @@ impl UserStoppedServiceTracker {
         tracker
     }
 
-    /// Mark a service as user-stopped
-    pub fn mark_user_stopped(&mut self, service_name: &str) -> Result<()> {
-        info!("Marking service '{}' as user-stopped", service_name);
-        self.user_stopped_services.insert(service_name.to_string());
-        self.save_to_storage()?;
-        debug!("Service '{}' marked as user-stopped and saved to storage", service_name);
-        Ok(())
-    }
 
     /// Clear user-stopped flag for a service (when user starts it)
     pub fn clear_user_stopped(&mut self, service_name: &str) -> Result<()> {

dashboard/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard"
-version = "0.1.73"
+version = "0.1.84"
 edition = "2021"
 
 [dependencies]

dashboard/src/app.rs

@@ -9,14 +9,13 @@ use std::io;
 use std::time::{Duration, Instant};
 use tracing::{debug, error, info, warn};
 
-use crate::communication::{AgentCommand, ServiceAction, ZmqCommandSender, ZmqConsumer};
+use crate::communication::{ZmqConsumer};
 use crate::config::DashboardConfig;
 use crate::metrics::MetricStore;
-use crate::ui::{TuiApp, UiCommand};
+use crate::ui::TuiApp;
 
 pub struct Dashboard {
     zmq_consumer: ZmqConsumer,
-    zmq_command_sender: ZmqCommandSender,
     metric_store: MetricStore,
     tui_app: Option<TuiApp>,
     terminal: Option<Terminal<CrosstermBackend<io::Stdout>>>,
@@ -58,14 +57,6 @@ impl Dashboard {
             }
         };
 
-        // Initialize ZMQ command sender
-        let zmq_command_sender = match ZmqCommandSender::new(&config.zmq) {
-            Ok(sender) => sender,
-            Err(e) => {
-                error!("Failed to initialize ZMQ command sender: {}", e);
-                return Err(e);
-            }
-        };
 
         // Try to connect to hosts but don't fail if none are available
         match zmq_consumer.connect_to_predefined_hosts(&config.hosts).await {
@@ -124,7 +115,6 @@ impl Dashboard {
 
         Ok(Self {
             zmq_consumer,
-            zmq_command_sender,
             metric_store,
             tui_app,
             terminal,
@@ -151,16 +141,10 @@ impl Dashboard {
                         match event::read() {
                             Ok(event) => {
                                 if let Some(ref mut tui_app) = self.tui_app {
-                                    // Handle input and check for commands
+                                    // Handle input
                                     match tui_app.handle_input(event) {
-                                        Ok(Some(command)) => {
-                                            // Execute the command
-                                            if let Err(e) = self.execute_ui_command(command).await {
-                                                error!("Failed to execute UI command: {}", e);
-                                            }
-                                        }
-                                        Ok(None) => {
-                                            // No command, check if we should quit
+                                        Ok(_) => {
+                                            // Check if we should quit
                                             if tui_app.should_quit() {
                                                 info!("Quit requested, exiting dashboard");
                                                 break;
@@ -287,33 +271,6 @@ impl Dashboard {
         Ok(())
     }
 
-    /// Execute a UI command by sending it to the appropriate agent
-    async fn execute_ui_command(&self, command: UiCommand) -> Result<()> {
-        match command {
-            UiCommand::ServiceStart { hostname, service_name } => {
-                info!("Sending user start command for service {} on {}", service_name, hostname);
-                let agent_command = AgentCommand::ServiceControl {
-                    service_name: service_name.clone(),
-                    action: ServiceAction::UserStart,
-                };
-                self.zmq_command_sender.send_command(&hostname, agent_command).await?;
-            }
-            UiCommand::ServiceStop { hostname, service_name } => {
-                info!("Sending user stop command for service {} on {}", service_name, hostname);
-                let agent_command = AgentCommand::ServiceControl {
-                    service_name: service_name.clone(),
-                    action: ServiceAction::UserStop,
-                };
-                self.zmq_command_sender.send_command(&hostname, agent_command).await?;
-            }
-            UiCommand::TriggerBackup { hostname } => {
-                info!("Trigger backup requested for {}", hostname);
-                // TODO: Implement backup trigger command
-                info!("Backup trigger not yet implemented");
-            }
-        }
-        Ok(())
-    }
 
 }
 

dashboard/src/communication/mod.rs

@@ -5,40 +5,6 @@ use zmq::{Context, Socket, SocketType};
 
 use crate::config::ZmqConfig;
 
-/// Commands that can be sent to agents
-#[derive(Debug, Clone, serde::Deserialize, serde::Serialize)]
-pub enum AgentCommand {
-    /// Request immediate metric collection
-    CollectNow,
-    /// Change collection interval
-    SetInterval { seconds: u64 },
-    /// Enable/disable a collector
-    ToggleCollector { name: String, enabled: bool },
-    /// Request status/health check
-    Ping,
-    /// Control systemd service
-    ServiceControl {
-        service_name: String,
-        action: ServiceAction,
-    },
-    /// Rebuild NixOS system
-    SystemRebuild {
-        git_url: String,
-        git_branch: String,
-        working_dir: String,
-        api_key_file: Option<String>,
-    },
-}
-
-/// Service control actions
-#[derive(Debug, Clone, serde::Deserialize, serde::Serialize)]
-pub enum ServiceAction {
-    Start,
-    Stop,
-    Status,
-    UserStart,  // User-initiated start (clears user-stopped flag)
-    UserStop,   // User-initiated stop (marks as user-stopped)
-}
 
 /// ZMQ consumer for receiving metrics from agents
 pub struct ZmqConsumer {
@@ -202,42 +168,3 @@ impl ZmqConsumer {
     }
 }
 
-/// ZMQ command sender for sending commands to agents
-pub struct ZmqCommandSender {
-    context: Context,
-}
-
-impl ZmqCommandSender {
-    pub fn new(_config: &ZmqConfig) -> Result<Self> {
-        let context = Context::new();
-
-        info!("ZMQ command sender initialized");
-
-        Ok(Self { context })
-    }
-
-    /// Send a command to a specific agent
-    pub async fn send_command(&self, hostname: &str, command: AgentCommand) -> Result<()> {
-        // Create a new PUSH socket for this command (ZMQ best practice)
-        let socket = self.context.socket(SocketType::PUSH)?;
-
-        // Set socket options
-        socket.set_linger(1000)?; // Wait up to 1 second on close
-        socket.set_sndtimeo(5000)?; // 5 second send timeout
-
-        // Connect to agent's command port (6131)
-        let address = format!("tcp://{}:6131", hostname);
-        socket.connect(&address)?;
-
-        // Serialize command
-        let serialized = serde_json::to_vec(&command)?;
-
-        // Send command
-        socket.send(&serialized, 0)?;
-
-        info!("Sent command {:?} to agent at {}", command, hostname);
-
-        // Socket will be automatically closed when dropped
-        Ok(())
-    }
-}

dashboard/src/config/mod.rs

@@ -51,11 +51,12 @@ pub struct SystemConfig {
     pub nixos_config_api_key_file: Option<String>,
 }
 
-/// SSH configuration for rebuild operations
+/// SSH configuration for rebuild and backup operations
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct SshConfig {
     pub rebuild_user: String,
     pub rebuild_alias: String,
+    pub backup_alias: String,
 }
 
 /// Service log file configuration per host

dashboard/src/ui/mod.rs

@@ -16,26 +16,12 @@ pub mod widgets;
 
 use crate::config::DashboardConfig;
 use crate::metrics::MetricStore;
-use cm_dashboard_shared::{Metric, Status};
+use cm_dashboard_shared::Status;
 use theme::{Components, Layout as ThemeLayout, Theme, Typography};
 use widgets::{BackupWidget, ServicesWidget, SystemWidget, Widget};
 
-/// Commands that can be triggered from the UI
-#[derive(Debug, Clone)]
-pub enum UiCommand {
-    ServiceStart { hostname: String, service_name: String },
-    ServiceStop { hostname: String, service_name: String },
-    TriggerBackup { hostname: String },
-}
 
 
-/// Types of commands for status tracking
-#[derive(Debug, Clone)]
-pub enum CommandType {
-    ServiceStart,
-    ServiceStop,
-    BackupTrigger,
-}
 
 /// Panel types for focus management
 
@@ -48,14 +34,8 @@ pub struct HostWidgets {
     pub services_widget: ServicesWidget,
     /// Backup widget state
     pub backup_widget: BackupWidget,
-    /// Scroll offsets for each panel
-    pub system_scroll_offset: usize,
-    pub services_scroll_offset: usize,
-    pub backup_scroll_offset: usize,
     /// Last update time for this host
     pub last_update: Option<Instant>,
-    /// Pending service transitions for immediate visual feedback
-    pub pending_service_transitions: HashMap<String, (CommandType, String, Instant)>, // service_name -> (command_type, original_status, start_time)
 }
 
 impl HostWidgets {
@@ -64,11 +44,7 @@ impl HostWidgets {
             system_widget: SystemWidget::new(),
             services_widget: ServicesWidget::new(),
             backup_widget: BackupWidget::new(),
-            system_scroll_offset: 0,
-            services_scroll_offset: 0,
-            backup_scroll_offset: 0,
             last_update: None,
-            pending_service_transitions: HashMap::new(),
         }
     }
 }
@@ -161,8 +137,6 @@ impl TuiApp {
                     }
                 }
 
-                // Clear completed transitions first
-                self.clear_completed_transitions(&hostname, &service_metrics);
 
                 // Now get host widgets and update them
                 let host_widgets = self.get_or_create_host_widgets(&hostname);
@@ -198,14 +172,6 @@ impl TuiApp {
             }
         }
         
-        // Keep hosts that have pending transitions even if they're offline
-        for (hostname, host_widgets) in &self.host_widgets {
-            if !host_widgets.pending_service_transitions.is_empty() {
-                if !all_hosts.contains(hostname) {
-                    all_hosts.push(hostname.clone());
-                }
-            }
-        }
         
         all_hosts.sort();
         self.available_hosts = all_hosts;
@@ -236,7 +202,7 @@ impl TuiApp {
     }
 
     /// Handle keyboard input
-    pub fn handle_input(&mut self, event: Event) -> Result<Option<UiCommand>> {
+    pub fn handle_input(&mut self, event: Event) -> Result<()> {
         if let Event::Key(key) = event {
             match key.code {
                 KeyCode::Char('q') => {
@@ -272,20 +238,78 @@ impl TuiApp {
                             .ok(); // Ignore errors, tmux will handle them
                     }
                 }
+                KeyCode::Char('B') => {
+                    // Backup command - works on any panel for current host
+                    if let Some(hostname) = self.current_host.clone() {
+                        let connection_ip = self.get_connection_ip(&hostname);
+                        // Create command that shows logo, runs backup, and waits for user input
+                        let logo_and_backup = format!(
+                            "bash -c 'cat << \"EOF\"\nBackup Operation\nTarget: {} ({})\n\nEOF\nssh -tt {}@{} \"bash -ic {}\"\necho\necho \"========================================\"\necho \"Backup completed. Press any key to close...\"\necho \"========================================\"\nread -n 1 -s\nexit'",
+                            hostname,
+                            connection_ip,
+                            self.config.ssh.rebuild_user,
+                            connection_ip,
+                            self.config.ssh.backup_alias
+                        );
+                        
+                        std::process::Command::new("tmux")
+                            .arg("split-window")
+                            .arg("-v")
+                            .arg("-p")
+                            .arg("30")
+                            .arg(&logo_and_backup)
+                            .spawn()
+                            .ok(); // Ignore errors, tmux will handle them
+                    }
+                }
                 KeyCode::Char('s') => {
-                    // Service start command
+                    // Service start command via SSH with progress display
                     if let (Some(service_name), Some(hostname)) = (self.get_selected_service(), self.current_host.clone()) {
-                        if self.start_command(&hostname, CommandType::ServiceStart, service_name.clone()) {
-                            return Ok(Some(UiCommand::ServiceStart { hostname, service_name }));
-                        }
+                        let connection_ip = self.get_connection_ip(&hostname);
+                        let service_start_command = format!(
+                            "bash -c 'cat << \"EOF\"\nService Start: {}\nTarget: {} ({})\n\nEOF\nssh -tt {}@{} \"echo \\\"Starting service and following logs (Ctrl+C to stop):\\\" && echo \\\"========================================\\\" && sudo systemctl start {} & sudo journalctl -fu {} --since=\\\"1 second ago\\\" --no-pager\"\necho\necho \"========================================\"\necho \"Operation completed. Press any key to close...\"\necho \"========================================\"\nread -n 1 -s\nexit'",
+                            service_name,
+                            hostname,
+                            connection_ip,
+                            self.config.ssh.rebuild_user,
+                            connection_ip,
+                            service_name,
+                            service_name
+                        );
+                        
+                        std::process::Command::new("tmux")
+                            .arg("split-window")
+                            .arg("-v")
+                            .arg("-p")
+                            .arg("30")
+                            .arg(&service_start_command)
+                            .spawn()
+                            .ok(); // Ignore errors, tmux will handle them
                     }
                 }
                 KeyCode::Char('S') => {
-                    // Service stop command
+                    // Service stop command via SSH with progress display
                     if let (Some(service_name), Some(hostname)) = (self.get_selected_service(), self.current_host.clone()) {
-                        if self.start_command(&hostname, CommandType::ServiceStop, service_name.clone()) {
-                            return Ok(Some(UiCommand::ServiceStop { hostname, service_name }));
-                        }
+                        let connection_ip = self.get_connection_ip(&hostname);
+                        let service_stop_command = format!(
+                            "bash -c 'cat << \"EOF\"\nService Stop: {}\nTarget: {} ({})\n\nEOF\nssh -tt {}@{} \"echo \\\"Stopping service and following logs (Ctrl+C to stop):\\\" && echo \\\"========================================\\\" && sudo systemctl stop {} & sudo journalctl -fu {} --since=\\\"1 second ago\\\" --no-pager\"\necho\necho \"========================================\"\necho \"Operation completed. Press any key to close...\"\necho \"========================================\"\nread -n 1 -s\nexit'",
+                            service_name,
+                            hostname,
+                            connection_ip,
+                            self.config.ssh.rebuild_user,
+                            connection_ip,
+                            service_name,
+                            service_name
+                        );
+                        
+                        std::process::Command::new("tmux")
+                            .arg("split-window")
+                            .arg("-v")
+                            .arg("-p")
+                            .arg("30")
+                            .arg(&service_stop_command)
+                            .spawn()
+                            .ok(); // Ignore errors, tmux will handle them
                     }
                 }
                 KeyCode::Char('J') => {
@@ -335,13 +359,6 @@ impl TuiApp {
                         }
                     }
                 }
-                KeyCode::Char('b') => {
-                    // Trigger backup
-                    if let Some(hostname) = self.current_host.clone() {
-                        self.start_command(&hostname, CommandType::BackupTrigger, hostname.clone());
-                        return Ok(Some(UiCommand::TriggerBackup { hostname }));
-                    }
-                }
                 KeyCode::Char('w') => {
                     // Wake on LAN for offline hosts
                     if let Some(hostname) = self.current_host.clone() {
@@ -414,7 +431,7 @@ impl TuiApp {
                 _ => {}
             }
         }
-        Ok(None)
+        Ok(())
     }
 
     /// Navigate between hosts
@@ -468,86 +485,8 @@ impl TuiApp {
         self.should_quit
     }
 
-    /// Get current service status for state-aware command validation
-    fn get_current_service_status(&self, hostname: &str, service_name: &str) -> Option<String> {
-        if let Some(host_widgets) = self.host_widgets.get(hostname) {
-            return host_widgets.services_widget.get_service_status(service_name);
-        }
-        None
-    }
 
-    /// Start command execution with immediate visual feedback 
-    pub fn start_command(&mut self, hostname: &str, command_type: CommandType, target: String) -> bool {
-        // Get current service status to validate command
-        let current_status = self.get_current_service_status(hostname, &target);
-        
-        // Validate if command makes sense for current state
-        let should_execute = match (&command_type, current_status.as_deref()) {
-            (CommandType::ServiceStart, Some("inactive") | Some("failed") | Some("dead")) => true,
-            (CommandType::ServiceStop, Some("active")) => true,
-            (CommandType::ServiceStart, Some("active")) => {
-                // Already running - don't execute
-                false
-            },
-            (CommandType::ServiceStop, Some("inactive") | Some("failed") | Some("dead")) => {
-                // Already stopped - don't execute  
-                false
-            },
-            (_, None) => {
-                // Unknown service state - allow command to proceed
-                true
-            },
-            _ => true, // Default: allow other combinations
-        };
-        
-        // ALWAYS store the pending transition for immediate visual feedback, even if we don't execute
-        if let Some(host_widgets) = self.host_widgets.get_mut(hostname) {
-            host_widgets.pending_service_transitions.insert(
-                target.clone(), 
-                (command_type, current_status.unwrap_or_else(|| "unknown".to_string()), Instant::now())
-            );
-        }
-        
-        should_execute
-    }
 
-    /// Clear pending transitions when real status updates arrive or timeout
-    fn clear_completed_transitions(&mut self, hostname: &str, service_metrics: &[&Metric]) {
-        if let Some(host_widgets) = self.host_widgets.get_mut(hostname) {
-            let mut completed_services = Vec::new();
-            
-            // Check each pending transition to see if real status has changed
-            for (service_name, (command_type, original_status, _start_time)) in &host_widgets.pending_service_transitions {
-                
-                // Look for status metric for this service
-                for metric in service_metrics {
-                    if metric.name == format!("service_{}_status", service_name) {
-                        let new_status = metric.value.as_string();
-                        
-                        // Check if status has changed from original (command completed)
-                        if &new_status != original_status {
-                            // Verify it changed in the expected direction
-                            let expected_change = match command_type {
-                                CommandType::ServiceStart => &new_status == "active",
-                                CommandType::ServiceStop => &new_status != "active",
-                                _ => false,
-                            };
-                            
-                            if expected_change {
-                                completed_services.push(service_name.clone());
-                            }
-                        }
-                        break;
-                    }
-                }
-            }
-            
-            // Remove completed transitions
-            for service_name in completed_services {
-                host_widgets.pending_service_transitions.remove(&service_name);
-            }
-        }
-    }
 
 
 
@@ -635,14 +574,10 @@ impl TuiApp {
         // Render services widget for current host
         if let Some(hostname) = self.current_host.clone() {
             let is_focused = true; // Always show service selection
-            let (scroll_offset, pending_transitions) = {
-                let host_widgets = self.get_or_create_host_widgets(&hostname);
-                (host_widgets.services_scroll_offset, host_widgets.pending_service_transitions.clone())
-            };
             let host_widgets = self.get_or_create_host_widgets(&hostname);
             host_widgets
                 .services_widget
-                .render_with_transitions(frame, content_chunks[1], is_focused, scroll_offset, &pending_transitions); // Services takes full right side
+                .render(frame, content_chunks[1], is_focused); // Services takes full right side
         }
 
         // Render statusbar at the bottom
@@ -769,6 +704,7 @@ impl TuiApp {
                 Status::Warning => has_warning = true,
                 Status::Pending => has_pending = true,
                 Status::Ok => ok_count += 1,
+                Status::Inactive => ok_count += 1, // Treat inactive as OK for aggregation
                 Status::Unknown => {}, // Ignore unknown for aggregation
                 Status::Offline => {}, // Ignore offline for aggregation
             }
@@ -825,14 +761,10 @@ impl TuiApp {
         frame.render_widget(system_block, area);
         // Get current host widgets, create if none exist
         if let Some(hostname) = self.current_host.clone() {
-            let scroll_offset = {
-                let host_widgets = self.get_or_create_host_widgets(&hostname);
-                host_widgets.system_scroll_offset
-            };
             // Clone the config to avoid borrowing issues
             let config = self.config.clone();
             let host_widgets = self.get_or_create_host_widgets(&hostname);
-            host_widgets.system_widget.render_with_scroll(frame, inner_area, scroll_offset, &hostname, Some(&config));
+            host_widgets.system_widget.render(frame, inner_area, &hostname, Some(&config));
         }
     }
 
@@ -843,12 +775,8 @@ impl TuiApp {
 
         // Get current host widgets for backup widget
         if let Some(hostname) = self.current_host.clone() {
-            let scroll_offset = {
-                let host_widgets = self.get_or_create_host_widgets(&hostname);
-                host_widgets.backup_scroll_offset
-            };
             let host_widgets = self.get_or_create_host_widgets(&hostname);
-            host_widgets.backup_widget.render_with_scroll(frame, inner_area, scroll_offset);
+            host_widgets.backup_widget.render(frame, inner_area);
         }
     }
 

dashboard/src/ui/theme.rs

@@ -143,6 +143,7 @@ impl Theme {
     pub fn status_color(status: Status) -> Color {
         match status {
             Status::Ok => Self::success(),
+            Status::Inactive => Self::muted_text(), // Gray for inactive services in service list
             Status::Pending => Self::highlight(), // Blue for pending
             Status::Warning => Self::warning(),
             Status::Critical => Self::error(),
@@ -243,6 +244,7 @@ impl StatusIcons {
     pub fn get_icon(status: Status) -> &'static str {
         match status {
             Status::Ok => "●",
+            Status::Inactive => "○", // Empty circle for inactive services
             Status::Pending => "◉", // Hollow circle for pending
             Status::Warning => "◐",
             Status::Critical => "!",
@@ -256,6 +258,7 @@ impl StatusIcons {
         let icon = Self::get_icon(status);
         let status_color = match status {
             Status::Ok => Theme::success(),         // Green
+            Status::Inactive => Theme::muted_text(), // Gray for inactive services
             Status::Pending => Theme::highlight(),       // Blue
             Status::Warning => Theme::warning(),    // Yellow
             Status::Critical => Theme::error(),     // Red

dashboard/src/ui/widgets/backup.rs

@@ -285,8 +285,8 @@ impl Widget for BackupWidget {
 }
 
 impl BackupWidget {
-    /// Render with scroll offset support
-    pub fn render_with_scroll(&mut self, frame: &mut Frame, area: Rect, scroll_offset: usize) {
+    /// Render backup widget
+    pub fn render(&mut self, frame: &mut Frame, area: Rect) {
         let mut lines = Vec::new();
 
         // Latest backup section
@@ -366,42 +366,20 @@ impl BackupWidget {
         let total_lines = lines.len();
         let available_height = area.height as usize;
         
-        // Calculate scroll boundaries
-        let max_scroll = if total_lines > available_height {
-            total_lines - available_height
-        } else {
-            total_lines.saturating_sub(1)
-        };
-        let effective_scroll = scroll_offset.min(max_scroll);
-        
-        // Apply scrolling if needed
-        if scroll_offset > 0 || total_lines > available_height {
+        // Show only what fits, with "X more below" if needed
+        if total_lines > available_height {
+            let lines_for_content = available_height.saturating_sub(1); // Reserve one line for "more below"
             let mut visible_lines: Vec<_> = lines
                 .into_iter()
-                .skip(effective_scroll)
-                .take(available_height)
+                .take(lines_for_content)
                 .collect();
             
-            // Add scroll indicator if there are hidden lines
-            if total_lines > available_height {
-                let hidden_above = effective_scroll;
-                let hidden_below = total_lines.saturating_sub(effective_scroll + available_height);
-                
-                if (hidden_above > 0 || hidden_below > 0) && !visible_lines.is_empty() {
-                    let scroll_text = if hidden_above > 0 && hidden_below > 0 {
-                        format!("... {} above, {} below", hidden_above, hidden_below)
-                    } else if hidden_above > 0 {
-                        format!("... {} more above", hidden_above)
-                    } else {
-                        format!("... {} more below", hidden_below)
-                    };
-                    
-                    // Replace last line with scroll indicator
-                    visible_lines.pop();
-                    visible_lines.push(ratatui::text::Line::from(vec![
-                        ratatui::text::Span::styled(scroll_text, Typography::muted())
-                    ]));
-                }
+            let hidden_below = total_lines.saturating_sub(lines_for_content);
+            if hidden_below > 0 {
+                let more_line = ratatui::text::Line::from(vec![
+                    ratatui::text::Span::styled(format!("... {} more below", hidden_below), Typography::muted())
+                ]);
+                visible_lines.push(more_line);
             }
             
             let paragraph = Paragraph::new(ratatui::text::Text::from(visible_lines));

dashboard/src/ui/widgets/services.rs

@@ -9,7 +9,6 @@ use tracing::debug;
 
 use super::Widget;
 use crate::ui::theme::{Components, StatusIcons, Theme, Typography};
-use crate::ui::CommandType;
 use ratatui::style::Style;
 
 /// Services widget displaying hierarchical systemd service statuses
@@ -125,41 +124,14 @@ impl ServicesWidget {
         )
     }
 
-    /// Get status icon for service, considering pending transitions for visual feedback
-    fn get_service_icon_and_status(&self, service_name: &str, info: &ServiceInfo, pending_transitions: &HashMap<String, (CommandType, String, std::time::Instant)>) -> (String, String, ratatui::prelude::Color) {
-        // Check if this service has a pending transition
-        if let Some((command_type, _original_status, _start_time)) = pending_transitions.get(service_name) {
-            // Show transitional icons for pending commands
-            let (icon, status_text) = match command_type {
-                CommandType::ServiceStart => ("↑", "starting"), 
-                CommandType::ServiceStop => ("↓", "stopping"),
-                _ => return (StatusIcons::get_icon(info.widget_status).to_string(), info.status.clone(), Theme::status_color(info.widget_status)), // Not a service command
-            };
-            return (icon.to_string(), status_text.to_string(), Theme::highlight());
-        }
-        
-        // Normal status display
-        let icon = StatusIcons::get_icon(info.widget_status);
-        let status_color = match info.widget_status {
-            Status::Ok => Theme::success(),
-            Status::Pending => Theme::highlight(),
-            Status::Warning => Theme::warning(),
-            Status::Critical => Theme::error(),
-            Status::Unknown => Theme::muted_text(),
-            Status::Offline => Theme::muted_text(),
-        };
-        
-        (icon.to_string(), info.status.clone(), status_color)
-    }
 
 
-    /// Create spans for sub-service with icon next to name, considering pending transitions
-    fn create_sub_service_spans_with_transitions(
+    /// Create spans for sub-service with icon next to name
+    fn create_sub_service_spans(
         &self,
         name: &str,
         info: &ServiceInfo,
         is_last: bool,
-        pending_transitions: &HashMap<String, (CommandType, String, std::time::Instant)>,
     ) -> Vec<ratatui::text::Span<'static>> {
         // Truncate long sub-service names to fit layout (accounting for indentation)
         let short_name = if name.len() > 18 {
@@ -168,19 +140,28 @@ impl ServicesWidget {
             name.to_string()
         };
 
-        // Get status icon and text, considering pending transitions
-        let (icon, mut status_str, status_color) = self.get_service_icon_and_status(name, info, pending_transitions);
+        // Get status icon and text
+        let icon = StatusIcons::get_icon(info.widget_status);
+        let status_color = match info.widget_status {
+            Status::Ok => Theme::success(),
+            Status::Inactive => Theme::muted_text(),
+            Status::Pending => Theme::highlight(),
+            Status::Warning => Theme::warning(),
+            Status::Critical => Theme::error(),
+            Status::Unknown => Theme::muted_text(),
+            Status::Offline => Theme::muted_text(),
+        };
 
-        // For sub-services, prefer latency if available (unless transition is pending)
-        if !pending_transitions.contains_key(name) {
-            if let Some(latency) = info.latency_ms {
-                status_str = if latency < 0.0 {
-                    "timeout".to_string()
-                } else {
-                    format!("{:.0}ms", latency)
-                };
+        // For sub-services, prefer latency if available
+        let status_str = if let Some(latency) = info.latency_ms {
+            if latency < 0.0 {
+                "timeout".to_string()
+            } else {
+                format!("{:.0}ms", latency)
             }
-        }
+        } else {
+            info.status.clone()
+        };
         let tree_symbol = if is_last { "└─" } else { "├─" };
 
         vec![
@@ -266,25 +247,6 @@ impl ServicesWidget {
         self.parent_services.len()
     }
 
-    /// Get current status of a specific service by name
-    pub fn get_service_status(&self, service_name: &str) -> Option<String> {
-        // Check if it's a parent service
-        if let Some(parent_info) = self.parent_services.get(service_name) {
-            return Some(parent_info.status.clone());
-        }
-        
-        // Check sub-services (format: parent_sub)
-        for (parent_name, sub_list) in &self.sub_services {
-            for (sub_name, sub_info) in sub_list {
-                let full_sub_name = format!("{}_{}", parent_name, sub_name);
-                if full_sub_name == service_name {
-                    return Some(sub_info.status.clone());
-                }
-            }
-        }
-        
-        None
-    }
 
     /// Calculate which parent service index corresponds to a display line index
     fn calculate_parent_service_index(&self, display_line_index: &usize) -> usize {
@@ -439,8 +401,8 @@ impl Widget for ServicesWidget {
 
 impl ServicesWidget {
 
-    /// Render with focus, scroll, and pending transitions for visual feedback
-    pub fn render_with_transitions(&mut self, frame: &mut Frame, area: Rect, is_focused: bool, scroll_offset: usize, pending_transitions: &HashMap<String, (CommandType, String, std::time::Instant)>) {
+    /// Render with focus
+    pub fn render(&mut self, frame: &mut Frame, area: Rect, is_focused: bool) {
         let services_block = Components::widget_block("services");
         let inner_area = services_block.inner(area);
         frame.render_widget(services_block, area);
@@ -465,14 +427,14 @@ impl ServicesWidget {
             return;
         }
 
-        // Use the existing render logic but with pending transitions
-        self.render_services_with_transitions(frame, content_chunks[1], is_focused, scroll_offset, pending_transitions);
+        // Render the services list
+        self.render_services(frame, content_chunks[1], is_focused);
     }
 
-    /// Render services list with pending transitions awareness
-    fn render_services_with_transitions(&mut self, frame: &mut Frame, area: Rect, is_focused: bool, scroll_offset: usize, pending_transitions: &HashMap<String, (CommandType, String, std::time::Instant)>) {
-        // Build hierarchical service list for display - include raw service name for pending transition lookups
-        let mut display_lines: Vec<(String, Status, bool, Option<(ServiceInfo, bool)>, String)> = Vec::new(); // Added raw service name
+    /// Render services list
+    fn render_services(&mut self, frame: &mut Frame, area: Rect, is_focused: bool) {
+        // Build hierarchical service list for display
+        let mut display_lines: Vec<(String, Status, bool, Option<(ServiceInfo, bool)>)> = Vec::new();
 
         // Sort parent services alphabetically for consistent order
         let mut parent_services: Vec<_> = self.parent_services.iter().collect();
@@ -481,7 +443,7 @@ impl ServicesWidget {
         for (parent_name, parent_info) in parent_services {
             // Add parent service line
             let parent_line = self.format_parent_service_line(parent_name, parent_info);
-            display_lines.push((parent_line, parent_info.widget_status, false, None, parent_name.clone())); // Include raw name
+            display_lines.push((parent_line, parent_info.widget_status, false, None));
 
             // Add sub-services for this parent (if any)
             if let Some(sub_list) = self.sub_services.get(parent_name) {
@@ -491,49 +453,48 @@ impl ServicesWidget {
 
                 for (i, (sub_name, sub_info)) in sorted_subs.iter().enumerate() {
                     let is_last_sub = i == sorted_subs.len() - 1;
-                    let full_sub_name = format!("{}_{}", parent_name, sub_name);
                     // Store sub-service info for custom span rendering
                     display_lines.push((
                         sub_name.clone(),
                         sub_info.widget_status,
                         true,
                         Some((sub_info.clone(), is_last_sub)),
-                        full_sub_name, // Raw service name for pending transition lookup
                     )); // true = sub-service, with is_last info
                 }
             }
         }
 
-        // Apply scroll offset and render visible lines (same as existing logic)
+        // Show only what fits, with "X more below" if needed
         let available_lines = area.height as usize;
         let total_lines = display_lines.len();
         
-        // Calculate scroll boundaries
-        let max_scroll = if total_lines > available_lines {
-            total_lines - available_lines
+        // Reserve one line for "X more below" if needed
+        let lines_for_content = if total_lines > available_lines {
+            available_lines.saturating_sub(1)
         } else {
-            total_lines.saturating_sub(1)
+            available_lines
         };
-        let effective_scroll = scroll_offset.min(max_scroll);
         
-        // Get visible lines after scrolling
         let visible_lines: Vec<_> = display_lines
             .iter()
-            .skip(effective_scroll)
-            .take(available_lines)
+            .take(lines_for_content)
             .collect();
         
+        let hidden_below = total_lines.saturating_sub(lines_for_content);
+        
         let lines_to_show = visible_lines.len();
 
         if lines_to_show > 0 {
+            // Add space for "X more below" message if needed
+            let total_chunks_needed = if hidden_below > 0 { lines_to_show + 1 } else { lines_to_show };
             let service_chunks = Layout::default()
                 .direction(Direction::Vertical)
-                .constraints(vec![Constraint::Length(1); lines_to_show])
+                .constraints(vec![Constraint::Length(1); total_chunks_needed])
                 .split(area);
 
-            for (i, (line_text, line_status, is_sub, sub_info, raw_service_name)) in visible_lines.iter().enumerate()
+            for (i, (line_text, line_status, is_sub, sub_info)) in visible_lines.iter().enumerate()
             {
-                let actual_index = effective_scroll + i; // Real index in the full list
+                let actual_index = i; // Simple index since we're not scrolling
                 
                 // Only parent services can be selected - calculate parent service index
                 let is_selected = if !*is_sub {
@@ -545,41 +506,16 @@ impl ServicesWidget {
                 };
                 
                 let mut spans = if *is_sub && sub_info.is_some() {
-                    // Use custom sub-service span creation WITH pending transitions
+                    // Use custom sub-service span creation
                     let (service_info, is_last) = sub_info.as_ref().unwrap();
-                    self.create_sub_service_spans_with_transitions(line_text, service_info, *is_last, pending_transitions)
+                    self.create_sub_service_spans(line_text, service_info, *is_last)
                 } else {
-                    // Parent services - check if this parent service has a pending transition using RAW service name
-                    if pending_transitions.contains_key(raw_service_name) {
-                        // Create spans with transitional status
-                        let (icon, status_text, _) = self.get_service_icon_and_status(raw_service_name, &ServiceInfo { 
-                            status: "".to_string(), 
-                            memory_mb: None, 
-                            disk_gb: None, 
-                            latency_ms: None, 
-                            widget_status: *line_status 
-                        }, pending_transitions);
-                        
-                        // Use blue for transitional icons when not selected, background color when selected
-                        let icon_color = if is_selected && !*is_sub && is_focused {
-                            Theme::background() // Dark background color for visibility against blue selection
-                        } else {
-                            Theme::highlight() // Blue for normal case
-                        };
-                        
-                        vec![
-                            ratatui::text::Span::styled(format!("{} ", icon), Style::default().fg(icon_color)),
-                            ratatui::text::Span::styled(line_text.clone(), Style::default().fg(Theme::primary_text())),
-                            ratatui::text::Span::styled(format!(" {}", status_text), Style::default().fg(icon_color)),
-                        ]
-                    } else {
-                        StatusIcons::create_status_spans(*line_status, line_text)
-                    }
+                    // Parent services - use normal status spans
+                    StatusIcons::create_status_spans(*line_status, line_text)
                 };
                 
-                // Apply selection highlighting to parent services only, making icons background color when selected
+                // Apply selection highlighting to parent services only
                 // Only show selection when Services panel is focused
-                // Show selection highlighting even when transitional icons are present
                 if is_selected && !*is_sub && is_focused {
                     for (i, span) in spans.iter_mut().enumerate() {
                         if i == 0 {
@@ -600,33 +536,12 @@ impl ServicesWidget {
                 
                 frame.render_widget(service_para, service_chunks[i]);
             }
-        }
-
-        // Show scroll indicator if there are more services than we can display (same as existing)
-        if total_lines > available_lines {
-            let hidden_above = effective_scroll;
-            let hidden_below = total_lines.saturating_sub(effective_scroll + available_lines);
             
-            if hidden_above > 0 || hidden_below > 0 {
-                let scroll_text = if hidden_above > 0 && hidden_below > 0 {
-                    format!("... {} above, {} below", hidden_above, hidden_below)
-                } else if hidden_above > 0 {
-                    format!("... {} more above", hidden_above)
-                } else {
-                    format!("... {} more below", hidden_below)
-                };
-                
-                if available_lines > 0 && lines_to_show > 0 {
-                    let last_line_area = Rect {
-                        x: area.x,
-                        y: area.y + (lines_to_show - 1) as u16,
-                        width: area.width,
-                        height: 1,
-                    };
-                    
-                    let scroll_para = Paragraph::new(scroll_text).style(Typography::muted());
-                    frame.render_widget(scroll_para, last_line_area);
-                }
+            // Show "X more below" message if content was truncated
+            if hidden_below > 0 {
+                let more_text = format!("... {} more below", hidden_below);
+                let more_para = Paragraph::new(more_text).style(Typography::muted());
+                frame.render_widget(more_para, service_chunks[lines_to_show]);
             }
         }
     }

dashboard/src/ui/widgets/system.rs

@@ -438,8 +438,8 @@ impl Widget for SystemWidget {
 }
 
 impl SystemWidget {
-    /// Render with scroll offset support
-    pub fn render_with_scroll(&mut self, frame: &mut Frame, area: Rect, scroll_offset: usize, hostname: &str, config: Option<&crate::config::DashboardConfig>) {
+    /// Render system widget  
+    pub fn render(&mut self, frame: &mut Frame, area: Rect, hostname: &str, config: Option<&crate::config::DashboardConfig>) {
         let mut lines = Vec::new();
 
         // NixOS section
@@ -560,22 +560,22 @@ impl SystemWidget {
         let total_lines = lines.len();
         let available_height = area.height as usize;
         
-        // Always apply scrolling if scroll_offset > 0, even if content fits
-        if scroll_offset > 0 || total_lines > available_height {
-            let max_scroll = if total_lines > available_height {
-                total_lines - available_height
-            } else {
-                total_lines.saturating_sub(1)
-            };
-            let effective_scroll = scroll_offset.min(max_scroll);
-            
-            // Take only the visible portion after scrolling
-            let visible_lines: Vec<Line> = lines
+        // Show only what fits, with "X more below" if needed
+        if total_lines > available_height {
+            let lines_for_content = available_height.saturating_sub(1); // Reserve one line for "more below"
+            let mut visible_lines: Vec<Line> = lines
                 .into_iter()
-                .skip(effective_scroll)
-                .take(available_height)
+                .take(lines_for_content)
                 .collect();
-                
+            
+            let hidden_below = total_lines.saturating_sub(lines_for_content);
+            if hidden_below > 0 {
+                let more_line = Line::from(vec![
+                    Span::styled(format!("... {} more below", hidden_below), Typography::muted())
+                ]);
+                visible_lines.push(more_line);
+            }
+            
             let paragraph = Paragraph::new(Text::from(visible_lines));
             frame.render_widget(paragraph, area);
         } else {

shared/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-shared"
-version = "0.1.73"
+version = "0.1.84"
 edition = "2021"
 
 [dependencies]

shared/src/metrics.rs

@@ -82,12 +82,13 @@ impl MetricValue {
 /// Health status for metrics
 #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub enum Status {
-    Ok,
+    Inactive, // Lowest priority - treated as good
+    Ok,       // Second lowest - also good
+    Unknown,
+    Offline,
     Pending,
     Warning,
     Critical,
-    Unknown,
-    Offline,
 }
 
 impl Status {
@@ -181,6 +182,16 @@ impl HysteresisThresholds {
                     Status::Ok
                 }
             }
+            Status::Inactive => {
+                // Inactive services use normal thresholds like first measurement
+                if value >= self.critical_high {
+                    Status::Critical
+                } else if value >= self.warning_high {
+                    Status::Warning
+                } else {
+                    Status::Ok
+                }
+            }
             Status::Pending => {
                 // Service transitioning, use normal thresholds like first measurement
                 if value >= self.critical_high {