Make nginx site latency thresholds configurable and simplify status logic

- Replace hardcoded 500ms/2000ms thresholds with configurable nginx_latency_critical_ms
- Simplify status logic to only OK or Critical (no Warning status)
- Add validation for nginx latency threshold configuration
- Re-enable nginx site collection with configurable thresholds
- Resolves issue where sites showed critical at 2000ms despite 30s timeout setting
- Bump version to v0.1.38

CLAUDE.md

@@ -18,22 +18,24 @@ All system panel features successfully implemented:
 - ✅ **Tmpfs Monitoring**: Added /tmp usage to RAM section
 - ✅ **Agent Deployment**: NixOS collector working in production
 
-**Keyboard Navigation and Service Management - COMPLETED** ✅
+**Simplified Navigation and Service Management - COMPLETED** ✅
 
-All keyboard navigation and service selection features successfully implemented:
-- ✅ **Panel Navigation**: Shift+Tab cycles through visible panels only (System → Services → Backup)
-- ✅ **Service Selection**: Up/Down arrows navigate through parent services with visual cursor
-- ✅ **Focus Management**: Selection highlighting only visible when Services panel focused
-- ✅ **Status Preservation**: Service health colors maintained during selection (green/red icons)
-- ✅ **Smart Panel Switching**: Only cycles through panels with data (backup panel conditional)
-- ✅ **Scroll Support**: All panels support content scrolling with proper overflow indicators
+All navigation and service management features successfully implemented:
+- ✅ **Direct Service Control**: Up/Down (or j/k) arrows directly control service selection
+- ✅ **Always Visible Selection**: Service selection highlighting always visible (no panel focus needed)
+- ✅ **Complete Service Discovery**: All configured services visible regardless of state
+- ✅ **Transitional Visual Feedback**: Service operations show directional arrows (↑ ↓ ↻)
+- ✅ **Simplified Interface**: Removed panel switching complexity, uniform appearance
+- ✅ **Vi-style Navigation**: Added j/k keys for vim users alongside arrow keys
 
-**Current Status - October 27, 2025:**
-- All keyboard navigation features working correctly ✅
-- Service selection cursor implemented with focus-aware highlighting ✅
-- Panel scrolling fixed for System, Services, and Backup panels ✅
+**Current Status - October 28, 2025:**
+- All service discovery and display features working correctly ✅
+- Simplified navigation system implemented ✅
+- Service selection always visible with direct control ✅
+- Complete service visibility (all configured services show regardless of state) ✅
+- Transitional service icons working with proper color handling ✅
 - Build display working: "Build: 25.05.20251004.3bcc93c" ✅
-- Agent version display working: "Agent: v0.1.17" ✅
+- Agent version display working: "Agent: v0.1.33" ✅
 - Cross-host version comparison implemented ✅
 - Automated binary release system working ✅
 - SMART data consolidated into disk collector ✅
@@ -76,36 +78,35 @@ Storage:
 **Backup panel visibility fixed - only shows when meaningful data exists ✅**
 **SSH-based rebuild system fully implemented and working ✅**
 
-### Current Keyboard Navigation Implementation
+### Current Simplified Navigation Implementation
 
 **Navigation Controls:**
 - **Tab**: Switch between hosts (cmbox, srv01, srv02, steambox, etc.)
-- **Shift+Tab**: Cycle through visible panels (System → Services → Backup → System)
-- **Up/Down (System/Backup)**: Scroll through panel content
-- **Up/Down (Services)**: Move service selection cursor between parent services
+- **↑↓ or j/k**: Move service selection cursor (always works)
 - **q**: Quit dashboard
 
-**Panel-Specific Features:**
-- **System Panel**: Scrollable content with CPU, RAM, Storage details
-- **Services Panel**: Service selection cursor for parent services only (docker, nginx, postgresql, etc.)
-- **Backup Panel**: Scrollable repository list with proper overflow handling
+**Service Control:**
+- **s**: Start selected service
+- **S**: Stop selected service  
+- **R**: Rebuild current host (works from any context)
 
-**Visual Feedback:**
-- **Focused Panel**: Blue border and title highlighting
-- **Service Selection**: Blue background with preserved status icon colors (green ● for active, red ● for failed)
-- **Focus-Aware Selection**: Selection highlighting only visible when Services panel focused
-- **Dynamic Statusbar**: Context-aware shortcuts based on focused panel
+**Visual Features:**
+- **Service Selection**: Always visible blue background highlighting current service
+- **Status Icons**: Green ● (active), Yellow ◐ (inactive), Red ◯ (failed), ? (unknown)
+- **Transitional Icons**: Blue ↑ (starting), ↓ (stopping), ↻ (restarting) when not selected
+- **Transitional Icons**: Dark gray arrows when service is selected (for visibility)
+- **Uniform Interface**: All panels have consistent appearance (no focus borders)
 
-### Remote Command Execution - WORKING ✅
+### Service Discovery and Display - WORKING ✅
 
-**All Issues Resolved (as of 2025-10-24):**
-- ✅ **ZMQ Command Protocol**: Extended with ServiceControl and SystemRebuild variants
-- ✅ **Agent Handlers**: systemctl and nixos-rebuild execution with maintenance mode
-- ✅ **Dashboard Integration**: Keyboard shortcuts execute commands
-- ✅ **Service Control**: Fixed toggle logic - replaced with separate 's' (start) and 'S' (stop)
-- ✅ **System Rebuild**: Fixed permission issues and sandboxing problems
-- ✅ **Git Clone Approach**: Implemented for nixos-rebuild to avoid directory permissions
-- ✅ **Visual Feedback**: Directional arrows for service status (↑ starting, ↓ stopping, ↻ restarting)
+**All Issues Resolved (as of 2025-10-28):**
+- ✅ **Complete Service Discovery**: Uses `systemctl list-unit-files` + `list-units --all` for comprehensive service detection
+- ✅ **All Services Visible**: Shows all configured services regardless of current state (active/inactive)
+- ✅ **Proper Status Display**: Active services show green ●, inactive show yellow ◐, failed show red ◯
+- ✅ **Transitional Icons**: Visual feedback during service operations with proper color handling
+- ✅ **Simplified Navigation**: Removed panel complexity, direct service control always available
+- ✅ **Service Control**: Start (s) and Stop (S) commands work from anywhere
+- ✅ **System Rebuild**: SSH + tmux popup approach for reliable remote rebuilds
 
 ### Terminal Popup for Real-time Output - IMPLEMENTED ✅
 

Cargo.lock

@@ -270,7 +270,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"
 
 [[package]]
 name = "cm-dashboard"
-version = "0.1.32"
+version = "0.1.37"
 dependencies = [
  "anyhow",
  "chrono",
@@ -291,7 +291,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-agent"
-version = "0.1.32"
+version = "0.1.37"
 dependencies = [
  "anyhow",
  "async-trait",
@@ -314,7 +314,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-shared"
-version = "0.1.32"
+version = "0.1.37"
 dependencies = [
  "chrono",
  "serde",

agent/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-agent"
-version = "0.1.33"
+version = "0.1.38"
 edition = "2021"
 
 [dependencies]

agent/src/collectors/systemd.rs

@@ -555,10 +555,8 @@ impl SystemdCollector {
         for (site_name, url) in &sites {
             match self.check_site_latency(url) {
                 Ok(latency_ms) => {
-                    let status = if latency_ms < 500.0 {
+                    let status = if latency_ms < self.config.nginx_latency_critical_ms {
                         Status::Ok
-                    } else if latency_ms < 2000.0 {
-                        Status::Warning
                     } else {
                         Status::Critical
                     };

agent/src/config/mod.rs

@@ -108,6 +108,7 @@ pub struct SystemdConfig {
     pub nginx_check_interval_seconds: u64,
     pub http_timeout_seconds: u64,
     pub http_connect_timeout_seconds: u64,
+    pub nginx_latency_critical_ms: f32,
 }
 
 

agent/src/config/validation.rs

@@ -83,6 +83,13 @@ pub fn validate_config(config: &AgentConfig) -> Result<()> {
         }
     }
 
+    // Validate systemd configuration
+    if config.collectors.systemd.enabled {
+        if config.collectors.systemd.nginx_latency_critical_ms <= 0.0 {
+            bail!("Nginx latency critical threshold must be positive");
+        }
+    }
+
     // Validate SMTP configuration
     if config.notifications.enabled {
         if config.notifications.smtp_host.is_empty() {

dashboard/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard"
-version = "0.1.33"
+version = "0.1.38"
 edition = "2021"
 
 [dependencies]

dashboard/src/ui/mod.rs

@@ -536,48 +536,87 @@ impl TuiApp {
 
         if self.available_hosts.is_empty() {
             let title_text = "cm-dashboard • no hosts discovered";
-            let title = Paragraph::new(title_text).style(Typography::title());
+            let title = Paragraph::new(title_text)
+                .style(Style::default().fg(Theme::background()).bg(Theme::status_color(Status::Unknown)));
             frame.render_widget(title, area);
             return;
         }
 
-        // Create spans for each host with status indicators
-        let mut spans = vec![Span::styled("cm-dashboard • ", Typography::title())];
+        // Calculate worst-case status across all hosts
+        let mut worst_status = Status::Ok;
+        for host in &self.available_hosts {
+            let host_status = self.calculate_host_status(host, metric_store);
+            worst_status = Status::aggregate(&[worst_status, host_status]);
+        }
 
+        // Use the worst status color as background
+        let background_color = Theme::status_color(worst_status);
+
+        // Split the title bar into left and right sections
+        let chunks = Layout::default()
+            .direction(Direction::Horizontal)
+            .constraints([Constraint::Length(15), Constraint::Min(0)])
+            .split(area);
+
+        // Left side: "cm-dashboard" text
+        let left_span = Span::styled(
+            " cm-dashboard", 
+            Style::default().fg(Theme::background()).bg(background_color)
+        );
+        let left_title = Paragraph::new(Line::from(vec![left_span]))
+            .style(Style::default().bg(background_color));
+        frame.render_widget(left_title, chunks[0]);
+
+        // Right side: hosts with status indicators
+        let mut host_spans = Vec::new();
+        
         for (i, host) in self.available_hosts.iter().enumerate() {
             if i > 0 {
-                spans.push(Span::styled(" ", Typography::title()));
+                host_spans.push(Span::styled(
+                    " ", 
+                    Style::default().fg(Theme::background()).bg(background_color)
+                ));
             }
 
             // Always show normal status icon based on metrics (no command status at host level)
             let host_status = self.calculate_host_status(host, metric_store);
-            let (status_icon, status_color) = (StatusIcons::get_icon(host_status), Theme::status_color(host_status));
+            let status_icon = StatusIcons::get_icon(host_status);
 
-            // Add status icon
-            spans.push(Span::styled(
+            // Add status icon with background color as foreground against status background
+            host_spans.push(Span::styled(
                 format!("{} ", status_icon),
-                Style::default().fg(status_color),
+                Style::default().fg(Theme::background()).bg(background_color),
             ));
 
             if Some(host) == self.current_host.as_ref() {
-                // Selected host in bold bright white
-                spans.push(Span::styled(
+                // Selected host in bold background color against status background
+                host_spans.push(Span::styled(
                     host.clone(),
-                    Typography::title().add_modifier(Modifier::BOLD),
+                    Style::default()
+                        .fg(Theme::background())
+                        .bg(background_color)
+                        .add_modifier(Modifier::BOLD),
                 ));
             } else {
-                // Other hosts in normal style with status color
-                spans.push(Span::styled(
+                // Other hosts in normal background color against status background
+                host_spans.push(Span::styled(
                     host.clone(),
-                    Style::default().fg(status_color),
+                    Style::default().fg(Theme::background()).bg(background_color),
                 ));
             }
         }
 
-        let title_line = Line::from(spans);
-        let title = Paragraph::new(vec![title_line]);
+        // Add right padding
+        host_spans.push(Span::styled(
+            " ", 
+            Style::default().fg(Theme::background()).bg(background_color)
+        ));
 
-        frame.render_widget(title, area);
+        let host_line = Line::from(host_spans);
+        let host_title = Paragraph::new(vec![host_line])
+            .style(Style::default().bg(background_color))
+            .alignment(ratatui::layout::Alignment::Right);
+        frame.render_widget(host_title, chunks[1]);
     }
 
     /// Calculate overall status for a host based on its metrics
@@ -642,12 +681,11 @@ impl TuiApp {
         // Global shortcuts
         shortcuts.push("Tab: Switch Host".to_string());
         shortcuts.push("↑↓/jk: Select Service".to_string());
-        shortcuts.push("R: Rebuild Host".to_string());
-        shortcuts.push("S: Start Service".to_string());
-        shortcuts.push("Shift+S: Stop Service".to_string());
+        shortcuts.push("r: Rebuild Host".to_string());
+        shortcuts.push("s/S: Start/Stop Service".to_string());
         
         // Always show quit
-        shortcuts.push("Q: Quit".to_string());
+        shortcuts.push("q: Quit".to_string());
         
         shortcuts
     }

dashboard/src/ui/widgets/services.rs

@@ -579,14 +579,16 @@ impl ServicesWidget {
                     }
                 };
                 
-                // Apply selection highlighting to parent services only, preserving status icon color
+                // Apply selection highlighting to parent services only, making icons background color when selected
                 // Only show selection when Services panel is focused
                 // Show selection highlighting even when transitional icons are present
                 if is_selected && !*is_sub && is_focused {
                     for (i, span) in spans.iter_mut().enumerate() {
                         if i == 0 {
-                            // First span is the status icon - preserve its color
-                            span.style = span.style.bg(Theme::highlight());
+                            // First span is the status icon - use background color for visibility against blue selection
+                            span.style = span.style
+                                .bg(Theme::highlight())
+                                .fg(Theme::background());
                         } else {
                             // Other spans (text) get full selection highlighting
                             span.style = span.style

dashboard/src/ui/widgets/system.rs

@@ -230,9 +230,30 @@ impl SystemWidget {
 
     /// Extract pool name from disk metric name
     fn extract_pool_name(&self, metric_name: &str) -> Option<String> {
-        if let Some(captures) = metric_name.strip_prefix("disk_") {
-            if let Some(pos) = captures.find('_') {
-                return Some(captures[..pos].to_string());
+        // Pattern: disk_{pool_name}_{drive_name}_{metric_type}
+        // Since pool_name can contain underscores, work backwards from known metric suffixes
+        if metric_name.starts_with("disk_") {
+            // First try drive-specific metrics that have device names
+            if let Some(suffix_pos) = metric_name.rfind("_temperature")
+                .or_else(|| metric_name.rfind("_wear_percent"))
+                .or_else(|| metric_name.rfind("_health")) {
+                // Find the second-to-last underscore to get pool name
+                let before_suffix = &metric_name[..suffix_pos];
+                if let Some(drive_start) = before_suffix.rfind('_') {
+                    return Some(metric_name[5..drive_start].to_string()); // Skip "disk_"
+                }
+            }
+            // For pool-level metrics (usage_percent, used_gb, total_gb), take everything before the metric suffix
+            else if let Some(suffix_pos) = metric_name.rfind("_usage_percent")
+                .or_else(|| metric_name.rfind("_used_gb"))
+                .or_else(|| metric_name.rfind("_total_gb")) {
+                return Some(metric_name[5..suffix_pos].to_string()); // Skip "disk_"
+            }
+            // Fallback to old behavior for unknown patterns
+            else if let Some(captures) = metric_name.strip_prefix("disk_") {
+                if let Some(pos) = captures.find('_') {
+                    return Some(captures[..pos].to_string());
+                }
             }
         }
         None
@@ -240,10 +261,18 @@ impl SystemWidget {
 
     /// Extract drive name from disk metric name  
     fn extract_drive_name(&self, metric_name: &str) -> Option<String> {
-        // Pattern: disk_pool_drive_metric
-        let parts: Vec<&str> = metric_name.split('_').collect();
-        if parts.len() >= 3 && parts[0] == "disk" {
-            return Some(parts[2].to_string());
+        // Pattern: disk_{pool_name}_{drive_name}_{metric_type}
+        // Since pool_name can contain underscores, work backwards from known metric suffixes
+        if metric_name.starts_with("disk_") {
+            if let Some(suffix_pos) = metric_name.rfind("_temperature")
+                .or_else(|| metric_name.rfind("_wear_percent"))
+                .or_else(|| metric_name.rfind("_health")) {
+                // Find the second-to-last underscore to get the drive name
+                let before_suffix = &metric_name[..suffix_pos];
+                if let Some(drive_start) = before_suffix.rfind('_') {
+                    return Some(before_suffix[drive_start + 1..].to_string());
+                }
+            }
         }
         None
     }

shared/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-shared"
-version = "0.1.33"
+version = "0.1.38"
 edition = "2021"
 
 [dependencies]