Fix service status detection with combined discovery and status approach

Enhanced service discovery to properly show status for all services:

Changes:
- Use systemctl list-unit-files for complete service discovery (finds all services)
- Use systemctl list-units --all for batch runtime status fetching
- Combine both datasets to get comprehensive service list with correct status
- Services found in unit-files but not runtime are marked as inactive (Warning status)
- Eliminates 'unknown' status issue while maintaining complete service visibility

Now inactive services show as Warning (yellow ◐) and active services show as Ok (green ●)
instead of all services showing as unknown (? icon).

Cargo.lock

@@ -270,7 +270,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"
 
 [[package]]
 name = "cm-dashboard"
-version = "0.1.27"
+version = "0.1.31"
 dependencies = [
  "anyhow",
  "chrono",
@@ -291,7 +291,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-agent"
-version = "0.1.27"
+version = "0.1.31"
 dependencies = [
  "anyhow",
  "async-trait",
@@ -314,7 +314,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-shared"
-version = "0.1.27"
+version = "0.1.31"
 dependencies = [
  "chrono",
  "serde",

agent/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-agent"
-version = "0.1.28"
+version = "0.1.32"
 edition = "2021"
 
 [dependencies]

agent/src/agent.rs

@@ -274,7 +274,6 @@ impl Agent {
         let action_str = match action {
             ServiceAction::Start => "start",
             ServiceAction::Stop => "stop", 
-            ServiceAction::Restart => "restart",
             ServiceAction::Status => "status",
         };
 
@@ -299,7 +298,7 @@ impl Agent {
         }
 
         // Force refresh metrics after service control to update service status
-        if matches!(action, ServiceAction::Start | ServiceAction::Stop | ServiceAction::Restart) {
+        if matches!(action, ServiceAction::Start | ServiceAction::Stop) {
             info!("Triggering immediate metric refresh after service control");
             if let Err(e) = self.collect_metrics_only().await {
                 error!("Failed to refresh metrics after service control: {}", e);

agent/src/collectors/systemd.rs

@@ -136,8 +136,21 @@ impl SystemdCollector {
     /// Auto-discover interesting services to monitor (internal version that doesn't update state)
     fn discover_services_internal(&self) -> Result<(Vec<String>, std::collections::HashMap<String, ServiceStatusInfo>)> {
         debug!("Starting systemd service discovery with status caching");
-        // Get all services (includes inactive, running, failed - everything)
-        let units_output = Command::new("systemctl")
+        
+        // First: Get all service unit files (includes services that have never been started)
+        let unit_files_output = Command::new("systemctl")
+            .arg("list-unit-files")
+            .arg("--type=service")
+            .arg("--no-pager")
+            .arg("--plain")
+            .output()?;
+
+        if !unit_files_output.status.success() {
+            return Err(anyhow::anyhow!("systemctl list-unit-files command failed"));
+        }
+
+        // Second: Get runtime status of all units
+        let units_status_output = Command::new("systemctl")
             .arg("list-units")
             .arg("--type=service")
             .arg("--all")
@@ -145,22 +158,33 @@ impl SystemdCollector {
             .arg("--plain")
             .output()?;
 
-        if !units_output.status.success() {
-            return Err(anyhow::anyhow!("systemctl system command failed"));
+        if !units_status_output.status.success() {
+            return Err(anyhow::anyhow!("systemctl list-units command failed"));
         }
 
-        let units_str = String::from_utf8(units_output.stdout)?;
+        let unit_files_str = String::from_utf8(unit_files_output.stdout)?;
+        let units_status_str = String::from_utf8(units_status_output.stdout)?;
         let mut services = Vec::new();
 
         // Use configuration instead of hardcoded values
         let excluded_services = &self.config.excluded_services;
         let service_name_filters = &self.config.service_name_filters;
 
-        // Parse all services and cache their status information
+        // Parse all service unit files to get complete service list
         let mut all_service_names = std::collections::HashSet::new();
-        let mut status_cache = std::collections::HashMap::new();
         
-        for line in units_str.lines() {
+        for line in unit_files_str.lines() {
+            let fields: Vec<&str> = line.split_whitespace().collect();
+            if fields.len() >= 2 && fields[0].ends_with(".service") {
+                let service_name = fields[0].trim_end_matches(".service");
+                all_service_names.insert(service_name.to_string());
+                debug!("Found service unit file: {}", service_name);
+            }
+        }
+
+        // Parse runtime status for all units
+        let mut status_cache = std::collections::HashMap::new();
+        for line in units_status_str.lines() {
             let fields: Vec<&str> = line.split_whitespace().collect();
             if fields.len() >= 4 && fields[0].ends_with(".service") {
                 let service_name = fields[0].trim_end_matches(".service");
@@ -177,8 +201,19 @@ impl SystemdCollector {
                     sub_state: sub_state.clone(),
                 });
 
-                all_service_names.insert(service_name.to_string());
-                debug!("Parsed service: {} (load:{}, active:{}, sub:{})", service_name, load_state, active_state, sub_state);
+                debug!("Got runtime status for service: {} (load:{}, active:{}, sub:{})", service_name, load_state, active_state, sub_state);
+            }
+        }
+
+        // For services found in unit files but not in runtime status, set default inactive status
+        for service_name in &all_service_names {
+            if !status_cache.contains_key(service_name) {
+                status_cache.insert(service_name.to_string(), ServiceStatusInfo {
+                    load_state: "not-loaded".to_string(),
+                    active_state: "inactive".to_string(),
+                    sub_state: "dead".to_string(),
+                });
+                debug!("Service {} found in unit files but not runtime - marked as inactive", service_name);
             }
         }
 

agent/src/communication/mod.rs

@@ -112,6 +112,5 @@ pub enum AgentCommand {
 pub enum ServiceAction {
     Start,
     Stop,
-    Restart,
     Status,
 }

dashboard/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard"
-version = "0.1.28"
+version = "0.1.32"
 edition = "2021"
 
 [dependencies]

dashboard/src/app.rs

@@ -294,14 +294,6 @@ impl Dashboard {
     /// Execute a UI command by sending it to the appropriate agent
     async fn execute_ui_command(&self, command: UiCommand) -> Result<()> {
         match command {
-            UiCommand::ServiceRestart { hostname, service_name } => {
-                info!("Sending restart command for service {} on {}", service_name, hostname);
-                let agent_command = AgentCommand::ServiceControl {
-                    service_name,
-                    action: ServiceAction::Restart,
-                };
-                self.zmq_command_sender.send_command(&hostname, agent_command).await?;
-            }
             UiCommand::ServiceStart { hostname, service_name } => {
                 info!("Sending start command for service {} on {}", service_name, hostname);
                 let agent_command = AgentCommand::ServiceControl {

dashboard/src/communication/mod.rs

@@ -35,7 +35,6 @@ pub enum AgentCommand {
 pub enum ServiceAction {
     Start,
     Stop,
-    Restart,
     Status,
 }
 

dashboard/src/main.rs

@@ -14,7 +14,7 @@ use app::Dashboard;
 
 /// Get hardcoded version
 fn get_version() -> &'static str {
-    "v0.1.28"
+    "v0.1.32"
 }
 
 /// Check if running inside tmux session

dashboard/src/ui/mod.rs

@@ -22,7 +22,6 @@ use widgets::{BackupWidget, ServicesWidget, SystemWidget, Widget};
 /// Commands that can be triggered from the UI
 #[derive(Debug, Clone)]
 pub enum UiCommand {
-    ServiceRestart { hostname: String, service_name: String },
     ServiceStart { hostname: String, service_name: String },
     ServiceStop { hostname: String, service_name: String },
     TriggerBackup { hostname: String },
@@ -32,7 +31,6 @@ pub enum UiCommand {
 /// Types of commands for status tracking
 #[derive(Debug, Clone)]
 pub enum CommandType {
-    ServiceRestart,
     ServiceStart,
     ServiceStop,
     BackupTrigger,
@@ -256,35 +254,20 @@ impl TuiApp {
                     self.navigate_host(1);
                 }
                 KeyCode::Char('r') => {
-                    match self.focused_panel {
-                        PanelType::System => {
-                            // Simple tmux popup with SSH rebuild using configured user and alias
-                            if let Some(hostname) = self.current_host.clone() {
-                                // Launch tmux popup with SSH using config values
-                                let ssh_command = format!(
-                                    "ssh -tt {}@{} 'bash -ic {}'",
-                                    self.config.ssh.rebuild_user,
-                                    hostname,
-                                    self.config.ssh.rebuild_alias
-                                );
-                                std::process::Command::new("tmux")
-                                    .arg("display-popup")
-                                    .arg(&ssh_command)
-                                    .spawn()
-                                    .ok(); // Ignore errors, tmux will handle them
-                            }
-                        }
-                        PanelType::Services => {
-                            // Service restart command
-                            if let (Some(service_name), Some(hostname)) = (self.get_selected_service(), self.current_host.clone()) {
-                                if self.start_command(&hostname, CommandType::ServiceRestart, service_name.clone()) {
-                                    return Ok(Some(UiCommand::ServiceRestart { hostname, service_name }));
-                                }
-                            }
-                        }
-                        _ => {
-                            info!("Manual refresh requested");
-                        }
+                    // System rebuild command - works on any panel for current host
+                    if let Some(hostname) = self.current_host.clone() {
+                        // Launch tmux popup with SSH using config values
+                        let ssh_command = format!(
+                            "ssh -tt {}@{} 'bash -ic {}'",
+                            self.config.ssh.rebuild_user,
+                            hostname,
+                            self.config.ssh.rebuild_alias
+                        );
+                        std::process::Command::new("tmux")
+                            .arg("display-popup")
+                            .arg(&ssh_command)
+                            .spawn()
+                            .ok(); // Ignore errors, tmux will handle them
                     }
                 }
                 KeyCode::Char('s') => {
@@ -431,7 +414,6 @@ impl TuiApp {
         let should_execute = match (&command_type, current_status.as_deref()) {
             (CommandType::ServiceStart, Some("inactive") | Some("failed") | Some("dead")) => true,
             (CommandType::ServiceStop, Some("active")) => true,
-            (CommandType::ServiceRestart, Some("active") | Some("inactive") | Some("failed") | Some("dead")) => true,
             (CommandType::ServiceStart, Some("active")) => {
                 // Already running - don't execute
                 false
@@ -462,15 +444,9 @@ impl TuiApp {
     fn clear_completed_transitions(&mut self, hostname: &str, service_metrics: &[&Metric]) {
         if let Some(host_widgets) = self.host_widgets.get_mut(hostname) {
             let mut completed_services = Vec::new();
-            let now = Instant::now();
             
-            // Check each pending transition to see if real status has changed or timed out
-            for (service_name, (command_type, original_status, start_time)) in &host_widgets.pending_service_transitions {
-                // Clear if too much time has passed (3 seconds for redundant commands)
-                if now.duration_since(*start_time).as_secs() > 3 {
-                    completed_services.push(service_name.clone());
-                    continue;
-                }
+            // Check each pending transition to see if real status has changed
+            for (service_name, (command_type, original_status, _start_time)) in &host_widgets.pending_service_transitions {
                 
                 // Look for status metric for this service
                 for metric in service_metrics {
@@ -483,7 +459,6 @@ impl TuiApp {
                             let expected_change = match command_type {
                                 CommandType::ServiceStart => &new_status == "active",
                                 CommandType::ServiceStop => &new_status != "active",
-                                CommandType::ServiceRestart => true, // Any change indicates restart completed
                                 _ => false,
                             };
                             
@@ -760,19 +735,19 @@ impl TuiApp {
         // Scroll shortcuts (always available)
         shortcuts.push("↑↓: Scroll".to_string());
         
+        // Global rebuild shortcut (works on any panel)
+        shortcuts.push("R: Rebuild Host".to_string());
+        
         // Panel-specific shortcuts
         match self.focused_panel {
-            PanelType::System => {
-                shortcuts.push("R: Rebuild".to_string());
-            }
             PanelType::Services => {
                 shortcuts.push("S: Start".to_string());
                 shortcuts.push("Shift+S: Stop".to_string());
-                shortcuts.push("R: Restart".to_string());
             }
             PanelType::Backup => {
                 shortcuts.push("B: Trigger Backup".to_string());
             }
+            _ => {}
         }
         
         // Always show quit

dashboard/src/ui/widgets/services.rs

@@ -134,7 +134,6 @@ impl ServicesWidget {
         if let Some((command_type, _original_status, _start_time)) = pending_transitions.get(service_name) {
             // Show transitional icons for pending commands
             let (icon, status_text) = match command_type {
-                CommandType::ServiceRestart => ("↻", "restarting"),
                 CommandType::ServiceStart => ("↑", "starting"), 
                 CommandType::ServiceStop => ("↓", "stopping"),
                 _ => return (StatusIcons::get_icon(info.widget_status).to_string(), info.status.clone(), Theme::status_color(info.widget_status)), // Not a service command
@@ -559,17 +558,25 @@ impl ServicesWidget {
                     // Parent services - check if this parent service has a pending transition using RAW service name
                     if pending_transitions.contains_key(raw_service_name) {
                         // Create spans with transitional status
-                        let (icon, status_text, status_color) = self.get_service_icon_and_status(raw_service_name, &ServiceInfo { 
+                        let (icon, status_text, _) = self.get_service_icon_and_status(raw_service_name, &ServiceInfo { 
                             status: "".to_string(), 
                             memory_mb: None, 
                             disk_gb: None, 
                             latency_ms: None, 
                             widget_status: *line_status 
                         }, pending_transitions);
+                        
+                        // Use blue for transitional icons when not selected, background color when selected
+                        let icon_color = if is_selected && !*is_sub && is_focused {
+                            Theme::background() // Dark background color for visibility against blue selection
+                        } else {
+                            Theme::highlight() // Blue for normal case
+                        };
+                        
                         vec![
-                            ratatui::text::Span::styled(format!("{} ", icon), Style::default().fg(status_color)),
+                            ratatui::text::Span::styled(format!("{} ", icon), Style::default().fg(icon_color)),
                             ratatui::text::Span::styled(line_text.clone(), Style::default().fg(Theme::primary_text())),
-                            ratatui::text::Span::styled(format!(" {}", status_text), Style::default().fg(status_color)),
+                            ratatui::text::Span::styled(format!(" {}", status_text), Style::default().fg(icon_color)),
                         ]
                     } else {
                         StatusIcons::create_status_spans(*line_status, line_text)
@@ -578,8 +585,8 @@ impl ServicesWidget {
                 
                 // Apply selection highlighting to parent services only, preserving status icon color
                 // Only show selection when Services panel is focused
-                // IMPORTANT: Don't override transitional icons that show pending commands
-                if is_selected && !*is_sub && is_focused && !pending_transitions.contains_key(raw_service_name) {
+                // Show selection highlighting even when transitional icons are present
+                if is_selected && !*is_sub && is_focused {
                     for (i, span) in spans.iter_mut().enumerate() {
                         if i == 0 {
                             // First span is the status icon - preserve its color

shared/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-shared"
-version = "0.1.28"
+version = "0.1.32"
 edition = "2021"
 
 [dependencies]