Treat pending status as OK for title bar color aggregation

Apply same logic used for inactive status to pending status. Pending services now contribute to OK count instead of being ignored, preventing blue title bar during service transitions.
Remove pending status from title bar color aggregation
2025-11-20 18:09:59 +01:00 · 2025-11-20 14:19:29 +01:00 · 2025-11-20 11:30:55 +01:00
6 changed files with 11 additions and 15 deletions
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -279,7 +279,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"

 [[package]]
 name = "cm-dashboard"
-version = "0.1.92"
+version = "0.1.95"
 dependencies = [
 "anyhow",
 "chrono",
@@ -301,7 +301,7 @@ dependencies = [

 [[package]]
 name = "cm-dashboard-agent"
-version = "0.1.92"
+version = "0.1.95"
 dependencies = [
 "anyhow",
 "async-trait",
@@ -324,7 +324,7 @@ dependencies = [

 [[package]]
 name = "cm-dashboard-shared"
-version = "0.1.92"
+version = "0.1.95"
 dependencies = [
 "chrono",
 "serde",
--- a/agent/Cargo.toml
+++ b/agent/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-agent"
-version = "0.1.93"
+version = "0.1.96"
 edition = "2021"

 [dependencies]
--- a/dashboard/Cargo.toml
+++ b/dashboard/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard"
-version = "0.1.93"
+version = "0.1.96"
 edition = "2021"

 [dependencies]
--- a/dashboard/src/config/mod.rs
+++ b/dashboard/src/config/mod.rs
@@ -57,7 +57,6 @@ pub struct SshConfig {
    pub rebuild_user: String,
    pub rebuild_cmd: String,
    pub service_manage_cmd: String,
-    pub service_logs_cmd: String,
 }

 /// Service log file configuration per host
--- a/dashboard/src/ui/mod.rs
+++ b/dashboard/src/ui/mod.rs
@@ -311,14 +311,14 @@ impl TuiApp {
                    }
                }
                KeyCode::Char('L') => {
-                    // Show service logs via script in tmux split window
+                    // Show service logs via service-manage script in tmux split window
                    if let (Some(service_name), Some(hostname)) = (self.get_selected_service(), self.current_host.clone()) {
                        let connection_ip = self.get_connection_ip(&hostname);
                        let logs_command = format!(
-                            "ssh -tt {}@{} '{} {}'",
+                            "ssh -tt {}@{} '{} logs {}'",
                            self.config.ssh.rebuild_user,
                            connection_ip,
-                            self.config.ssh.service_logs_cmd,
+                            self.config.ssh.service_manage_cmd,
                            service_name
                        );
                        
@@ -669,14 +669,13 @@ impl TuiApp {
        // Fallback to old aggregation logic with proper Pending handling
        let mut has_critical = false;
        let mut has_warning = false;
-        let mut has_pending = false;
        let mut ok_count = 0;

        for metric in &metrics {
            match metric.status {
                Status::Critical => has_critical = true,
                Status::Warning => has_warning = true,
-                Status::Pending => has_pending = true,
+                Status::Pending => ok_count += 1, // Treat pending as OK for aggregation
                Status::Ok => ok_count += 1,
                Status::Inactive => ok_count += 1, // Treat inactive as OK for aggregation
                Status::Unknown => {}, // Ignore unknown for aggregation
@@ -684,13 +683,11 @@ impl TuiApp {
            }
        }

-        // Priority order: Critical > Warning > Pending > Ok > Unknown
+        // Priority order: Critical > Warning > Ok > Unknown (no Pending)
        if has_critical {
            Status::Critical
        } else if has_warning {
            Status::Warning
-        } else if has_pending {
-            Status::Pending
        } else if ok_count > 0 {
            Status::Ok
        } else {
--- a/shared/Cargo.toml
+++ b/shared/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-shared"
-version = "0.1.93"
+version = "0.1.96"
 edition = "2021"

 [dependencies]
Author	SHA1	Message	Date
Christoffer Martinsson	5d6b8e6253	Treat pending status as OK for title bar color aggregation All checks were successful Build and Release / build-and-release (push) Successful in 1m12s Details Apply same logic used for inactive status to pending status. Pending services now contribute to OK count instead of being ignored, preventing blue title bar during service transitions.	2025-11-20 18:09:59 +01:00
Christoffer Martinsson	0cba083305	Remove pending status from title bar color aggregation All checks were successful Build and Release / build-and-release (push) Successful in 2m9s Details Title bar now only shows Critical (red), Warning (yellow), and OK (green) colors. Pending status is ignored in color calculation to prevent blue title bar during service transitions.	2025-11-20 14:19:29 +01:00
Christoffer Martinsson	a6be7a4788	Consolidate log viewing to use service-manage logs action All checks were successful Build and Release / build-and-release (push) Successful in 1m31s Details Replace separate service_logs_cmd with service-manage logs action to unify service management through single script interface. Dashboard now calls 'service-manage logs <service>' which provides intelligent log viewing based on service state and configuration.	2025-11-20 11:30:55 +01:00