Fix filesystem metric parsing bounds error in dashboard

Prevent string slicing panic in extract_filesystem_metric when parsing individual filesystem metrics. This resolves the issue where filesystem entries show —% —GB/—GB instead of actual usage.
Fix disk collector filesystem discovery with debug logging
2025-11-23 15:23:15 +01:00 · 2025-11-23 15:15:56 +01:00 · 2025-11-23 14:52:09 +01:00 · 2025-11-23 14:45:00 +01:00
6 changed files with 23 additions and 12 deletions
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -279,7 +279,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"

 [[package]]
 name = "cm-dashboard"
-version = "0.1.109"
+version = "0.1.114"
 dependencies = [
 "anyhow",
 "chrono",
@@ -301,7 +301,7 @@ dependencies = [

 [[package]]
 name = "cm-dashboard-agent"
-version = "0.1.109"
+version = "0.1.114"
 dependencies = [
 "anyhow",
 "async-trait",
@@ -324,7 +324,7 @@ dependencies = [

 [[package]]
 name = "cm-dashboard-shared"
-version = "0.1.109"
+version = "0.1.114"
 dependencies = [
 "chrono",
 "serde",
--- a/agent/Cargo.toml
+++ b/agent/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-agent"
-version = "0.1.110"
+version = "0.1.114"
 edition = "2021"

 [dependencies]
--- a/agent/src/collectors/disk.rs
+++ b/agent/src/collectors/disk.rs
@@ -148,9 +148,14 @@ impl DiskCollector {
        let mut filesystem_usage = HashMap::new();
        
        for mount_point in mount_devices.keys() {
-            if let Ok((total, used)) = self.get_filesystem_info(mount_point) {
+            match self.get_filesystem_info(mount_point) {
+                Ok((total, used)) => {
                    filesystem_usage.insert(mount_point.clone(), (total, used));
                }
+                Err(e) => {
+                    debug!("Failed to get filesystem info for {}: {}", mount_point, e);
+                }
+            }
        }
        
        Ok(filesystem_usage)
--- a/dashboard/Cargo.toml
+++ b/dashboard/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard"
-version = "0.1.110"
+version = "0.1.114"
 edition = "2021"

 [dependencies]
--- a/dashboard/src/ui/widgets/system.rs
+++ b/dashboard/src/ui/widgets/system.rs
@@ -350,9 +350,11 @@ impl SystemWidget {
                // Find the second-to-last underscore to get pool name
                let before_suffix = &metric_name[..suffix_pos];
                if let Some(drive_start) = before_suffix.rfind('_') {
+                    if drive_start > 5 {
                        return Some(metric_name[5..drive_start].to_string()); // Skip "disk_"
                    }
                }
+            }
            // Handle filesystem metrics: disk_{pool}_fs_{filesystem}_{metric}
            else if metric_name.contains("_fs_") {
                if let Some(fs_pos) = metric_name.find("_fs_") {
@@ -389,12 +391,16 @@ impl SystemWidget {
                
                for suffix in known_suffixes {
                    if after_fs.ends_with(suffix) {
-                        let fs_name = after_fs[..after_fs.len() - suffix.len() - 1].to_string(); // Remove suffix + underscore
+                        // Safely calculate fs_name length
+                        let suffix_with_underscore = suffix.len() + 1;
+                        if after_fs.len() > suffix_with_underscore {
+                            let fs_name = after_fs[..after_fs.len() - suffix_with_underscore].to_string();
                            return (Some(fs_name), Some(suffix.to_string()));
                        }
                    }
                }
            }
+        }
        (None, None)
    }

--- a/shared/Cargo.toml
+++ b/shared/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-shared"
-version = "0.1.110"
+version = "0.1.114"
 edition = "2021"

 [dependencies]
Author	SHA1	Message	Date
Christoffer Martinsson	de30b80219	Fix filesystem metric parsing bounds error in dashboard All checks were successful Build and Release / build-and-release (push) Successful in 1m8s Details Prevent string slicing panic in extract_filesystem_metric when parsing individual filesystem metrics. This resolves the issue where filesystem entries show —% —GB/—GB instead of actual usage.	2025-11-23 15:23:15 +01:00
Christoffer Martinsson	7d96ca9fad	Fix disk collector filesystem discovery with debug logging All checks were successful Build and Release / build-and-release (push) Successful in 1m9s Details Add debug logging to filesystem usage collection to identify why some mount points are being dropped during discovery. This should resolve the issue where total capacity shows incorrect values.	2025-11-23 15:15:56 +01:00
Christoffer Martinsson	9b940ebd19	Fix string slicing bounds error in metric parsing All checks were successful Build and Release / build-and-release (push) Successful in 1m8s Details Fixed critical bug where dashboard crashed with 'begin <= end' slice error when parsing disk metrics with new naming format. Added bounds checking to prevent invalid string slicing operations. - Fixed extract_pool_name string slicing bounds check - Removed ineffective panic handling that caused infinite loop - Dashboard now handles new disk collector metrics correctly	2025-11-23 14:52:09 +01:00
Christoffer Martinsson	6d4da1b7da	Add robust error handling to prevent dashboard crashes All checks were successful Build and Release / build-and-release (push) Successful in 2m9s Details Added comprehensive error handling to storage metrics parsing to prevent dashboard crashes when encountering unexpected metric formats or parsing errors. Dashboard now continues gracefully with empty storage display instead of crashing, improving reliability during metric format changes. - Wrapped storage metric parsing in panic recovery - Added logging for metric parsing failures - Dashboard shows empty storage on errors instead of crashing - Ensures dashboard remains functional during agent updates	2025-11-23 14:45:00 +01:00