cm/cm-dashboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 261 Wiki Activity

Add info-level logging for SMART data collection debugging
All checks were successful
Build and Release / build-and-release (push) Successful in 1m19s
Details

Browse Source
This commit is contained in:
Christoffer Martinsson 2025-11-27 13:15:53 +01:00
parent 5dd8cadef3
commit bbc8b7b1cb
5 changed files with 27 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Cargo.lock generated
View File

@ -279,7 +279,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"
[[package]] [[package]]
name = "cm-dashboard" name = "cm-dashboard"
version = "0.1.178" version = "0.1.179"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"chrono", "chrono",
@ -301,7 +301,7 @@ dependencies = [
[[package]] [[package]]
name = "cm-dashboard-agent" name = "cm-dashboard-agent"
version = "0.1.178" version = "0.1.179"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"async-trait", "async-trait",
@ -324,7 +324,7 @@ dependencies = [
[[package]] [[package]]
name = "cm-dashboard-shared" name = "cm-dashboard-shared"
version = "0.1.178" version = "0.1.179"
dependencies = [ dependencies = [
"chrono", "chrono",
"serde", "serde",

2
agent/Cargo.toml
View File

@ -1,6 +1,6 @@
[package] [package]
name = "cm-dashboard-agent" name = "cm-dashboard-agent"
version = "0.1.179" version = "0.1.180"
edition = "2021" edition = "2021"
[dependencies] [dependencies]

29
agent/src/collectors/disk.rs
View File

@ -385,8 +385,9 @@ impl DiskCollector {
/// Get SMART data for drives /// Get SMART data for drives
async fn get_smart_data_for_drives(&self, physical_drives: &[PhysicalDrive], mergerfs_pools: &[MergerfsPool]) -> HashMap<String, SmartData> { async fn get_smart_data_for_drives(&self, physical_drives: &[PhysicalDrive], mergerfs_pools: &[MergerfsPool]) -> HashMap<String, SmartData> {
use tracing::info;
let mut smart_data = HashMap::new(); let mut smart_data = HashMap::new();
// Collect all drive names // Collect all drive names
let mut all_drives = std::collections::HashSet::new(); let mut all_drives = std::collections::HashSet::new();
for drive in physical_drives { for drive in physical_drives {
@ -401,18 +402,30 @@ impl DiskCollector {
} }
} }
info!("Collecting SMART data for {} drives", all_drives.len());
// Get SMART data for each drive // Get SMART data for each drive
for drive_name in all_drives { for drive_name in &all_drives {
if let Ok(data) = self.get_smart_data(&drive_name).await { match self.get_smart_data(drive_name).await {
smart_data.insert(drive_name, data); Ok(data) => {
info!("SMART data collected for {}: serial={:?}, temp={:?}, health={}",
drive_name, data.serial_number, data.temperature_celsius, data.health);
smart_data.insert(drive_name.clone(), data);
}
Err(e) => {
info!("Failed to get SMART data for {}: {:?}", drive_name, e);
}
} }
} }
info!("SMART data collection complete: {}/{} drives successful", smart_data.len(), all_drives.len());
smart_data smart_data
} }
/// Get SMART data for a single drive /// Get SMART data for a single drive
async fn get_smart_data(&self, drive_name: &str) -> Result<SmartData, CollectorError> { async fn get_smart_data(&self, drive_name: &str) -> Result<SmartData, CollectorError> {
use tracing::info;
let output = Command::new("sudo") let output = Command::new("sudo")
.args(&["smartctl", "-a", &format!("/dev/{}", drive_name)]) .args(&["smartctl", "-a", &format!("/dev/{}", drive_name)])
.output() .output()
@ -423,13 +436,13 @@ impl DiskCollector {
let output_str = String::from_utf8_lossy(&output.stdout); let output_str = String::from_utf8_lossy(&output.stdout);
let error_str = String::from_utf8_lossy(&output.stderr); let error_str = String::from_utf8_lossy(&output.stderr);
// Debug logging for SMART command results // Debug logging for SMART command results
debug!("SMART output for {}: status={}, stdout_len={}, stderr={}", debug!("SMART output for {}: status={}, stdout_len={}, stderr={}",
drive_name, output.status, output_str.len(), error_str); drive_name, output.status, output_str.len(), error_str);
if !output.status.success() { if !output.status.success() {
debug!("SMART command failed for {}: {}", drive_name, error_str); info!("SMART command failed for {}, status={}, stderr={}", drive_name, output.status, error_str);
// Return unknown data rather than failing completely // Return unknown data rather than failing completely
return Ok(SmartData { return Ok(SmartData {
health: "UNKNOWN".to_string(), health: "UNKNOWN".to_string(),

2
dashboard/Cargo.toml
View File

@ -1,6 +1,6 @@
[package] [package]
name = "cm-dashboard" name = "cm-dashboard"
version = "0.1.179" version = "0.1.180"
edition = "2021" edition = "2021"
[dependencies] [dependencies]

2
shared/Cargo.toml
View File

@ -1,6 +1,6 @@
[package] [package]
name = "cm-dashboard-shared" name = "cm-dashboard-shared"
version = "0.1.179" version = "0.1.180"
edition = "2021" edition = "2021"
[dependencies] [dependencies]