From 97aa1708c2cb2bf3a7229716fcb8f67c865c8343 Mon Sep 17 00:00:00 2001
From: Christoffer Martinsson <cm@cmtec.se>
Date: Tue, 28 Oct 2025 18:17:15 +0100
Subject: [PATCH] Improve service selection UI and help text

- Fix service icons to use background color when selected for better visibility against blue selection background
- Combine start/stop service help text entries into single "s/S: Start/Stop Service"
- Change help text keys to lowercase (r: Rebuild Host, q: Quit)
- Bump version to v0.1.34
---
 Cargo.lock                           | 6 +++---
 agent/Cargo.toml                     | 2 +-
 dashboard/Cargo.toml                 | 2 +-
 dashboard/src/ui/mod.rs              | 7 +++----
 dashboard/src/ui/widgets/services.rs | 8 +++++---
 shared/Cargo.toml                    | 2 +-
 6 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 870fd0d..40bfb86 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -270,7 +270,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"
 
 [[package]]
 name = "cm-dashboard"
-version = "0.1.32"
+version = "0.1.33"
 dependencies = [
  "anyhow",
  "chrono",
@@ -291,7 +291,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-agent"
-version = "0.1.32"
+version = "0.1.33"
 dependencies = [
  "anyhow",
  "async-trait",
@@ -314,7 +314,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-shared"
-version = "0.1.32"
+version = "0.1.33"
 dependencies = [
  "chrono",
  "serde",
diff --git a/agent/Cargo.toml b/agent/Cargo.toml
index 57004a1..3433421 100644
--- a/agent/Cargo.toml
+++ b/agent/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-agent"
-version = "0.1.33"
+version = "0.1.34"
 edition = "2021"
 
 [dependencies]
diff --git a/dashboard/Cargo.toml b/dashboard/Cargo.toml
index d32a964..132f4f2 100644
--- a/dashboard/Cargo.toml
+++ b/dashboard/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard"
-version = "0.1.33"
+version = "0.1.34"
 edition = "2021"
 
 [dependencies]
diff --git a/dashboard/src/ui/mod.rs b/dashboard/src/ui/mod.rs
index c1e6585..4a1d87f 100644
--- a/dashboard/src/ui/mod.rs
+++ b/dashboard/src/ui/mod.rs
@@ -642,12 +642,11 @@ impl TuiApp {
         // Global shortcuts
         shortcuts.push("Tab: Switch Host".to_string());
         shortcuts.push("↑↓/jk: Select Service".to_string());
-        shortcuts.push("R: Rebuild Host".to_string());
-        shortcuts.push("S: Start Service".to_string());
-        shortcuts.push("Shift+S: Stop Service".to_string());
+        shortcuts.push("r: Rebuild Host".to_string());
+        shortcuts.push("s/S: Start/Stop Service".to_string());
         
         // Always show quit
-        shortcuts.push("Q: Quit".to_string());
+        shortcuts.push("q: Quit".to_string());
         
         shortcuts
     }
diff --git a/dashboard/src/ui/widgets/services.rs b/dashboard/src/ui/widgets/services.rs
index 1acc3c5..bf15781 100644
--- a/dashboard/src/ui/widgets/services.rs
+++ b/dashboard/src/ui/widgets/services.rs
@@ -579,14 +579,16 @@ impl ServicesWidget {
                     }
                 };
                 
-                // Apply selection highlighting to parent services only, preserving status icon color
+                // Apply selection highlighting to parent services only, making icons background color when selected
                 // Only show selection when Services panel is focused
                 // Show selection highlighting even when transitional icons are present
                 if is_selected && !*is_sub && is_focused {
                     for (i, span) in spans.iter_mut().enumerate() {
                         if i == 0 {
-                            // First span is the status icon - preserve its color
-                            span.style = span.style.bg(Theme::highlight());
+                            // First span is the status icon - use background color for visibility against blue selection
+                            span.style = span.style
+                                .bg(Theme::highlight())
+                                .fg(Theme::background());
                         } else {
                             // Other spans (text) get full selection highlighting
                             span.style = span.style
diff --git a/shared/Cargo.toml b/shared/Cargo.toml
index 55e27f8..b3134df 100644
--- a/shared/Cargo.toml
+++ b/shared/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-shared"
-version = "0.1.33"
+version = "0.1.34"
 edition = "2021"
 
 [dependencies]