cm/cm-dashboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 266 Wiki Activity

Remove debug logging for NVMe SMART collection
All checks were successful
Build and Release / build-and-release (push) Successful in 1m9s
Details

Browse Source
This commit is contained in:
Christoffer Martinsson 2025-11-27 15:40:16 +01:00
parent 5be67fed64
commit 7a68da01f5
5 changed files with 11 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Cargo.lock generated
View File

@ -279,7 +279,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"
[[package]] [[package]]
name = "cm-dashboard" name = "cm-dashboard"
version = "0.1.182" version = "0.1.183"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"chrono", "chrono",
@ -301,7 +301,7 @@ dependencies = [
[[package]] [[package]]
name = "cm-dashboard-agent" name = "cm-dashboard-agent"
version = "0.1.182" version = "0.1.183"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"async-trait", "async-trait",
@ -324,7 +324,7 @@ dependencies = [
[[package]] [[package]]
name = "cm-dashboard-shared" name = "cm-dashboard-shared"
version = "0.1.182" version = "0.1.183"
dependencies = [ dependencies = [
"chrono", "chrono",
"serde", "serde",

2
agent/Cargo.toml
View File

@ -1,6 +1,6 @@
[package] [package]
name = "cm-dashboard-agent" name = "cm-dashboard-agent"
version = "0.1.183" version = "0.1.184"
edition = "2021" edition = "2021"
[dependencies] [dependencies]

23
agent/src/collectors/disk.rs
View File

@ -413,9 +413,7 @@ impl DiskCollector {
/// Get SMART data for a single drive /// Get SMART data for a single drive
async fn get_smart_data(&self, drive_name: &str) -> Result<SmartData, CollectorError> { async fn get_smart_data(&self, drive_name: &str) -> Result<SmartData, CollectorError> {
use tracing::info; // Use direct smartctl (no sudo) - service has CAP_SYS_RAWIO and CAP_SYS_ADMIN capabilities
// Use direct smartctl (no sudo) - service has CAP_SYS_RAWIO capability
// For NVMe drives, specify device type explicitly // For NVMe drives, specify device type explicitly
let mut cmd = Command::new("smartctl"); let mut cmd = Command::new("smartctl");
if drive_name.starts_with("nvme") { if drive_name.starts_with("nvme") {
@ -433,10 +431,6 @@ impl DiskCollector {
let output_str = String::from_utf8_lossy(&output.stdout); let output_str = String::from_utf8_lossy(&output.stdout);
if !output.status.success() { if !output.status.success() {
if drive_name.starts_with("nvme") {
info!("NVMe SMART failed for {}: status={}, stderr={}",
drive_name, output.status, String::from_utf8_lossy(&output.stderr));
}
// Return unknown data rather than failing completely // Return unknown data rather than failing completely
return Ok(SmartData { return Ok(SmartData {
health: "UNKNOWN".to_string(), health: "UNKNOWN".to_string(),
@ -521,19 +515,12 @@ impl DiskCollector {
} }
} }
let smart_data = SmartData { Ok(SmartData {
health: health.clone(), health,
serial_number: serial_number.clone(), serial_number,
temperature_celsius: temperature, temperature_celsius: temperature,
wear_percent, wear_percent,
}; })
if drive_name.starts_with("nvme") {
info!("NVMe SMART parsed for {}: serial={:?}, temp={:?}, health={}, wear={:?}",
drive_name, serial_number, temperature, health, wear_percent);
}
Ok(smart_data)
} }
/// Populate drives data into AgentData /// Populate drives data into AgentData

2
dashboard/Cargo.toml
View File

@ -1,6 +1,6 @@
[package] [package]
name = "cm-dashboard" name = "cm-dashboard"
version = "0.1.183" version = "0.1.184"
edition = "2021" edition = "2021"
[dependencies] [dependencies]

2
shared/Cargo.toml
View File

@ -1,6 +1,6 @@
[package] [package]
name = "cm-dashboard-shared" name = "cm-dashboard-shared"
version = "0.1.183" version = "0.1.184"
edition = "2021" edition = "2021"
[dependencies] [dependencies]