Implement immediate transitional service icons with pending state tracking

- Replace timeout-based command status with pending service transitions
- Show immediate directional arrows when pressing service commands (↑ ↓ ↻)
- Track original service status and command type for each pending operation
- Automatically clear transitional icons when real status updates arrive
- Remove unused TerminalPopup and CommandStatus infrastructure
- Simplify visual feedback system using state-based approach

Service commands now provide instant visual feedback that persists until
the actual service state changes, eliminating timing issues and improving UX.

dashboard/src/ui/widgets/services.rs

@@ -9,7 +9,7 @@ use tracing::debug;
 
 use super::Widget;
 use crate::ui::theme::{Components, StatusIcons, Theme, Typography};
-use crate::ui::{CommandStatus, CommandType};
+use crate::ui::CommandType;
 use ratatui::style::Style;
 
 /// Services widget displaying hierarchical systemd service statuses
@@ -128,25 +128,18 @@ impl ServicesWidget {
         )
     }
 
-    /// Get status icon for service, considering command status for visual feedback
-    fn get_service_icon_and_status(&self, service_name: &str, info: &ServiceInfo, command_status: Option<&CommandStatus>) -> (String, String, ratatui::prelude::Color) {
-        // Check if this service is currently being operated on
-        if let Some(status) = command_status {
-            match status {
-                CommandStatus::InProgress { command_type, target, .. } => {
-                    if target == service_name {
-                        // Only show special icons for service commands
-                        if let Some((icon, status_text)) = match command_type {
-                            CommandType::ServiceRestart => Some(("↻", "restarting")),
-                            CommandType::ServiceStart => Some(("↑", "starting")), 
-                            CommandType::ServiceStop => Some(("↓", "stopping")),
-                            _ => None, // Don't handle non-service commands here
-                        } {
-                            return (icon.to_string(), status_text.to_string(), Theme::highlight());
-                        }
-                    }
-                }
-            }
+    /// Get status icon for service, considering pending transitions for visual feedback
+    fn get_service_icon_and_status(&self, service_name: &str, info: &ServiceInfo, pending_transitions: &HashMap<String, (CommandType, String)>) -> (String, String, ratatui::prelude::Color) {
+        // Check if this service has a pending transition
+        if let Some((command_type, _original_status)) = pending_transitions.get(service_name) {
+            // Show transitional icons for pending commands
+            let (icon, status_text) = match command_type {
+                CommandType::ServiceRestart => ("↻", "restarting"),
+                CommandType::ServiceStart => ("↑", "starting"), 
+                CommandType::ServiceStop => ("↓", "stopping"),
+                _ => return (StatusIcons::get_icon(info.widget_status).to_string(), info.status.clone(), Theme::status_color(info.widget_status)), // Not a service command
+            };
+            return (icon.to_string(), status_text.to_string(), Theme::highlight());
         }
         
         // Normal status display
@@ -163,13 +156,13 @@ impl ServicesWidget {
     }
 
 
-    /// Create spans for sub-service with icon next to name, considering command status
-    fn create_sub_service_spans_with_status(
+    /// Create spans for sub-service with icon next to name, considering pending transitions
+    fn create_sub_service_spans_with_transitions(
         &self,
         name: &str,
         info: &ServiceInfo,
         is_last: bool,
-        command_status: Option<&CommandStatus>,
+        pending_transitions: &HashMap<String, (CommandType, String)>,
     ) -> Vec<ratatui::text::Span<'static>> {
         // Truncate long sub-service names to fit layout (accounting for indentation)
         let short_name = if name.len() > 18 {
@@ -178,11 +171,11 @@ impl ServicesWidget {
             name.to_string()
         };
 
-        // Get status icon and text, considering command status
-        let (icon, mut status_str, status_color) = self.get_service_icon_and_status(name, info, command_status);
+        // Get status icon and text, considering pending transitions
+        let (icon, mut status_str, status_color) = self.get_service_icon_and_status(name, info, pending_transitions);
 
-        // For sub-services, prefer latency if available (unless command is in progress)
-        if command_status.is_none() {
+        // For sub-services, prefer latency if available (unless transition is pending)
+        if !pending_transitions.contains_key(name) {
             if let Some(latency) = info.latency_ms {
                 status_str = if latency < 0.0 {
                     "timeout".to_string()
@@ -446,8 +439,8 @@ impl Widget for ServicesWidget {
 
 impl ServicesWidget {
 
-    /// Render with focus, scroll, and command status for visual feedback
-    pub fn render_with_command_status(&mut self, frame: &mut Frame, area: Rect, is_focused: bool, scroll_offset: usize, command_status: Option<&CommandStatus>) {
+    /// Render with focus, scroll, and pending transitions for visual feedback
+    pub fn render_with_transitions(&mut self, frame: &mut Frame, area: Rect, is_focused: bool, scroll_offset: usize, pending_transitions: &HashMap<String, (CommandType, String)>) {
         let services_block = if is_focused {
             Components::focused_widget_block("services")
         } else {
@@ -476,12 +469,12 @@ impl ServicesWidget {
             return;
         }
 
-        // Use the existing render logic but with command status
-        self.render_services_with_status(frame, content_chunks[1], is_focused, scroll_offset, command_status);
+        // Use the existing render logic but with pending transitions
+        self.render_services_with_transitions(frame, content_chunks[1], is_focused, scroll_offset, pending_transitions);
     }
 
-    /// Render services list with command status awareness
-    fn render_services_with_status(&mut self, frame: &mut Frame, area: Rect, is_focused: bool, scroll_offset: usize, command_status: Option<&CommandStatus>) {
+    /// Render services list with pending transitions awareness
+    fn render_services_with_transitions(&mut self, frame: &mut Frame, area: Rect, is_focused: bool, scroll_offset: usize, pending_transitions: &HashMap<String, (CommandType, String)>) {
         // Build hierarchical service list for display (same as existing logic)
         let mut display_lines: Vec<(String, Status, bool, Option<(ServiceInfo, bool)>)> = Vec::new();
 
@@ -554,37 +547,28 @@ impl ServicesWidget {
                 };
                 
                 let mut spans = if *is_sub && sub_info.is_some() {
-                    // Use custom sub-service span creation WITH command status
+                    // Use custom sub-service span creation WITH pending transitions
                     let (service_info, is_last) = sub_info.as_ref().unwrap();
-                    self.create_sub_service_spans_with_status(line_text, service_info, *is_last, command_status)
+                    self.create_sub_service_spans_with_transitions(line_text, service_info, *is_last, pending_transitions)
                 } else {
-                    // Parent services - check if this parent service has a command in progress
-                    let service_spans = if let Some(status) = command_status {
-                        match status {
-                            CommandStatus::InProgress { target, .. } => {
-                                if target == line_text {
-                                    // Create spans with progress status
-                                    let (icon, status_text, status_color) = self.get_service_icon_and_status(line_text, &ServiceInfo { 
-                                        status: "".to_string(), 
-                                        memory_mb: None, 
-                                        disk_gb: None, 
-                                        latency_ms: None, 
-                                        widget_status: *line_status 
-                                    }, command_status);
-                                    vec![
-                                        ratatui::text::Span::styled(format!("{} ", icon), Style::default().fg(status_color)),
-                                        ratatui::text::Span::styled(line_text.clone(), Style::default().fg(Theme::primary_text())),
-                                        ratatui::text::Span::styled(format!(" {}", status_text), Style::default().fg(status_color)),
-                                    ]
-                                } else {
-                                    StatusIcons::create_status_spans(*line_status, line_text)
-                                }
-                            }
-                        }
+                    // Parent services - check if this parent service has a pending transition
+                    if pending_transitions.contains_key(line_text) {
+                        // Create spans with transitional status
+                        let (icon, status_text, status_color) = self.get_service_icon_and_status(line_text, &ServiceInfo { 
+                            status: "".to_string(), 
+                            memory_mb: None, 
+                            disk_gb: None, 
+                            latency_ms: None, 
+                            widget_status: *line_status 
+                        }, pending_transitions);
+                        vec![
+                            ratatui::text::Span::styled(format!("{} ", icon), Style::default().fg(status_color)),
+                            ratatui::text::Span::styled(line_text.clone(), Style::default().fg(Theme::primary_text())),
+                            ratatui::text::Span::styled(format!(" {}", status_text), Style::default().fg(status_color)),
+                        ]
                     } else {
                         StatusIcons::create_status_spans(*line_status, line_text)
-                    };
-                    service_spans
+                    }
                 };
                 
                 // Apply selection highlighting to parent services only, preserving status icon color