From 6a1324ba6c14df66c9f214ffd681d3a27cf2985b Mon Sep 17 00:00:00 2001
From: Christoffer Martinsson <cm@cmtec.se>
Date: Fri, 24 Oct 2025 18:26:31 +0200
Subject: [PATCH] Update CLAUDE.md status after implementing separate service
 start/stop commands

---
 CLAUDE.md | 48 +++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 37 insertions(+), 11 deletions(-)

diff --git a/CLAUDE.md b/CLAUDE.md
index 56ea7de..482ca76 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -79,18 +79,26 @@ Storage:
 
 ### Current Priority: Visual Feedback Implementation
 
-**Remote Command Execution - COMPLETED** ✅
+**Remote Command Execution - PARTIALLY WORKING** ⚠️
 
-All core remote command functionality implemented:
+Core infrastructure implemented but issues remain:
 - ✅ **ZMQ Command Protocol**: Extended with ServiceControl and SystemRebuild variants
 - ✅ **Agent Handlers**: systemctl and nixos-rebuild execution with maintenance mode
 - ✅ **Dashboard Integration**: Existing keyboard shortcuts now execute commands
-- ✅ **Command Flow**: UI → Dashboard → ZMQ → Agent → systemctl/nixos-rebuild
+- ⚠️ **Service Control**: systemctl commands work but Space key toggle needs fixing
+- ❌ **System Rebuild**: nixos-rebuild still failing with permission denied
 
-**Keyboard Controls Working:**
-- **Services Panel**: Space (start/stop), R (restart)  
-- **System Panel**: R (nixos-rebuild)
-- **Backup Panel**: B (trigger backup)
+**Current Issues (as of 2025-10-23):**
+1. **Service Toggle Bug**: Space key always sends "Start" instead of toggling start/stop
+2. **nixos-rebuild Permissions**: Still getting permission denied despite sudo config updates
+3. **No Command Completion**: Visual feedback shows ⏳ but never completes (missing response protocol)
+
+**Keyboard Controls Status:**
+- **Services Panel**: 
+  - R (restart) ✅ Working
+  - Space (start/stop) ❌ Always starts, doesn't toggle
+- **System Panel**: R (nixos-rebuild) ❌ Permission denied
+- **Backup Panel**: B (trigger backup) ❓ Not tested
 
 **Visual Feedback Implementation - IN PROGRESS:**
 
@@ -116,10 +124,28 @@ Latest backup:              →    Latest backup:
 └─ Duration: 1.3m                 └─ [██████       ] 60%
 ```
 
-**Remaining Tasks:**
-- Implement visual feedback system for command execution status
-- Add confirmation dialogs for destructive actions  
-- Test complete command execution scenarios
+**Next Session Priority Tasks:**
+
+**Critical Fixes Needed:**
+1. **Fix Service Toggle Logic**: Debug why Space key service status detection isn't working
+   - Check systemd metric format (`systemd_{service}_status`)
+   - Test service status parsing logic  
+   - Ensure toggle detects active vs inactive correctly
+
+2. **Resolve nixos-rebuild Permissions**: 
+   - Verify sudo rules are actually applied after NixOS rebuild
+   - Test `sudo -u cm-agent sudo nixos-rebuild --help` manually
+   - May need different approach for nixos-rebuild access
+
+3. **Implement Command Response Protocol**:
+   - Agent sends command completion/failure back to dashboard via ZMQ
+   - Dashboard updates UI status from ⏳ to ● when commands complete
+   - Clear success/failure status after timeout
+
+**Secondary Tasks:**
+- Add confirmation dialogs for destructive actions (stop/restart/rebuild)
+- Complete visual feedback for System and Backup panels
+- Test backup trigger functionality
 
 **Future Enhanced Navigation:**
 - Add Page Up/Down for faster scrolling through long service lists