From 651b801de37b9e6510214654f49202660092fb28 Mon Sep 17 00:00:00 2001 From: Christoffer Martinsson Date: Tue, 28 Oct 2025 14:22:40 +0100 Subject: [PATCH] Fix transitional service icons being overridden by selection highlighting MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Prevent selection highlighting when service has pending transition - Allow directional arrows (↑ ↓ ↻) to show through on selected services - Fix core issue where selection styling was overwriting transitional icons - Transitional icons now properly visible during service command execution The selection highlighting logic now skips services with pending transitions, ensuring that directional arrows are visible when executing service commands. --- Cargo.lock | 6 +++--- agent/Cargo.toml | 2 +- dashboard/Cargo.toml | 2 +- dashboard/src/main.rs | 2 +- dashboard/src/ui/widgets/services.rs | 3 ++- shared/Cargo.toml | 2 +- 6 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 3e07c8f..3c1606b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -270,7 +270,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d" [[package]] name = "cm-dashboard" -version = "0.1.23" +version = "0.1.24" dependencies = [ "anyhow", "chrono", @@ -291,7 +291,7 @@ dependencies = [ [[package]] name = "cm-dashboard-agent" -version = "0.1.23" +version = "0.1.24" dependencies = [ "anyhow", "async-trait", @@ -314,7 +314,7 @@ dependencies = [ [[package]] name = "cm-dashboard-shared" -version = "0.1.23" +version = "0.1.24" dependencies = [ "chrono", "serde", diff --git a/agent/Cargo.toml b/agent/Cargo.toml index 229c3c8..186fdf2 100644 --- a/agent/Cargo.toml +++ b/agent/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "cm-dashboard-agent" -version = "0.1.24" +version = "0.1.25" edition = "2021" [dependencies] diff --git a/dashboard/Cargo.toml b/dashboard/Cargo.toml index d3b1854..a1416d7 100644 --- a/dashboard/Cargo.toml +++ b/dashboard/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "cm-dashboard" -version = "0.1.24" +version = "0.1.25" edition = "2021" [dependencies] diff --git a/dashboard/src/main.rs b/dashboard/src/main.rs index 26c2cb3..527f4f0 100644 --- a/dashboard/src/main.rs +++ b/dashboard/src/main.rs @@ -14,7 +14,7 @@ use app::Dashboard; /// Get hardcoded version fn get_version() -> &'static str { - "v0.1.24" + "v0.1.25" } /// Check if running inside tmux session diff --git a/dashboard/src/ui/widgets/services.rs b/dashboard/src/ui/widgets/services.rs index d431c54..f76ed7b 100644 --- a/dashboard/src/ui/widgets/services.rs +++ b/dashboard/src/ui/widgets/services.rs @@ -573,7 +573,8 @@ impl ServicesWidget { // Apply selection highlighting to parent services only, preserving status icon color // Only show selection when Services panel is focused - if is_selected && !*is_sub && is_focused { + // IMPORTANT: Don't override transitional icons that show pending commands + if is_selected && !*is_sub && is_focused && !pending_transitions.contains_key(line_text) { for (i, span) in spans.iter_mut().enumerate() { if i == 0 { // First span is the status icon - preserve its color diff --git a/shared/Cargo.toml b/shared/Cargo.toml index e6fcdca..138b9fb 100644 --- a/shared/Cargo.toml +++ b/shared/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "cm-dashboard-shared" -version = "0.1.24" +version = "0.1.25" edition = "2021" [dependencies]