From 5be67fed64c836653d25731fa30b1b9f2ca39521 Mon Sep 17 00:00:00 2001
From: Christoffer Martinsson <cm@cmtec.se>
Date: Thu, 27 Nov 2025 15:00:48 +0100
Subject: [PATCH] Add debug logging for NVMe SMART data collection

---
 Cargo.lock                   |  6 +++---
 agent/Cargo.toml             |  2 +-
 agent/src/collectors/disk.rs | 21 +++++++++++++++++----
 dashboard/Cargo.toml         |  2 +-
 shared/Cargo.toml            |  2 +-
 5 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 275dc7c..0a4620e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -279,7 +279,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d"
 
 [[package]]
 name = "cm-dashboard"
-version = "0.1.181"
+version = "0.1.182"
 dependencies = [
  "anyhow",
  "chrono",
@@ -301,7 +301,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-agent"
-version = "0.1.181"
+version = "0.1.182"
 dependencies = [
  "anyhow",
  "async-trait",
@@ -324,7 +324,7 @@ dependencies = [
 
 [[package]]
 name = "cm-dashboard-shared"
-version = "0.1.181"
+version = "0.1.182"
 dependencies = [
  "chrono",
  "serde",
diff --git a/agent/Cargo.toml b/agent/Cargo.toml
index 7780a63..e980735 100644
--- a/agent/Cargo.toml
+++ b/agent/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-agent"
-version = "0.1.182"
+version = "0.1.183"
 edition = "2021"
 
 [dependencies]
diff --git a/agent/src/collectors/disk.rs b/agent/src/collectors/disk.rs
index cc7ba15..fcc49d5 100644
--- a/agent/src/collectors/disk.rs
+++ b/agent/src/collectors/disk.rs
@@ -413,6 +413,8 @@ impl DiskCollector {
 
     /// Get SMART data for a single drive
     async fn get_smart_data(&self, drive_name: &str) -> Result<SmartData, CollectorError> {
+        use tracing::info;
+
         // Use direct smartctl (no sudo) - service has CAP_SYS_RAWIO capability
         // For NVMe drives, specify device type explicitly
         let mut cmd = Command::new("smartctl");
@@ -431,6 +433,10 @@ impl DiskCollector {
         let output_str = String::from_utf8_lossy(&output.stdout);
 
         if !output.status.success() {
+            if drive_name.starts_with("nvme") {
+                info!("NVMe SMART failed for {}: status={}, stderr={}",
+                    drive_name, output.status, String::from_utf8_lossy(&output.stderr));
+            }
             // Return unknown data rather than failing completely
             return Ok(SmartData {
                 health: "UNKNOWN".to_string(),
@@ -515,12 +521,19 @@ impl DiskCollector {
             }
         }
 
-        Ok(SmartData {
-            health,
-            serial_number,
+        let smart_data = SmartData {
+            health: health.clone(),
+            serial_number: serial_number.clone(),
             temperature_celsius: temperature,
             wear_percent,
-        })
+        };
+
+        if drive_name.starts_with("nvme") {
+            info!("NVMe SMART parsed for {}: serial={:?}, temp={:?}, health={}, wear={:?}",
+                drive_name, serial_number, temperature, health, wear_percent);
+        }
+
+        Ok(smart_data)
     }
 
     /// Populate drives data into AgentData
diff --git a/dashboard/Cargo.toml b/dashboard/Cargo.toml
index 085a1fb..07ead81 100644
--- a/dashboard/Cargo.toml
+++ b/dashboard/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard"
-version = "0.1.182"
+version = "0.1.183"
 edition = "2021"
 
 [dependencies]
diff --git a/shared/Cargo.toml b/shared/Cargo.toml
index 5ca653f..0f3524b 100644
--- a/shared/Cargo.toml
+++ b/shared/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "cm-dashboard-shared"
-version = "0.1.182"
+version = "0.1.183"
 edition = "2021"
 
 [dependencies]