From 0cba083305bf711cfda05b3dc535c2f1a893f07b Mon Sep 17 00:00:00 2001 From: Christoffer Martinsson Date: Thu, 20 Nov 2025 14:19:29 +0100 Subject: [PATCH] Remove pending status from title bar color aggregation Title bar now only shows Critical (red), Warning (yellow), and OK (green) colors. Pending status is ignored in color calculation to prevent blue title bar during service transitions. --- Cargo.lock | 6 +++--- agent/Cargo.toml | 2 +- dashboard/Cargo.toml | 2 +- dashboard/src/ui/mod.rs | 7 ++----- shared/Cargo.toml | 2 +- 5 files changed, 8 insertions(+), 11 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index dcf6f0f..2883192 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -279,7 +279,7 @@ checksum = "a1d728cc89cf3aee9ff92b05e62b19ee65a02b5702cff7d5a377e32c6ae29d8d" [[package]] name = "cm-dashboard" -version = "0.1.93" +version = "0.1.94" dependencies = [ "anyhow", "chrono", @@ -301,7 +301,7 @@ dependencies = [ [[package]] name = "cm-dashboard-agent" -version = "0.1.93" +version = "0.1.94" dependencies = [ "anyhow", "async-trait", @@ -324,7 +324,7 @@ dependencies = [ [[package]] name = "cm-dashboard-shared" -version = "0.1.93" +version = "0.1.94" dependencies = [ "chrono", "serde", diff --git a/agent/Cargo.toml b/agent/Cargo.toml index f9e8b8e..4b1954f 100644 --- a/agent/Cargo.toml +++ b/agent/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "cm-dashboard-agent" -version = "0.1.94" +version = "0.1.95" edition = "2021" [dependencies] diff --git a/dashboard/Cargo.toml b/dashboard/Cargo.toml index 9547652..5ac4420 100644 --- a/dashboard/Cargo.toml +++ b/dashboard/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "cm-dashboard" -version = "0.1.94" +version = "0.1.95" edition = "2021" [dependencies] diff --git a/dashboard/src/ui/mod.rs b/dashboard/src/ui/mod.rs index 91000e1..11822e5 100644 --- a/dashboard/src/ui/mod.rs +++ b/dashboard/src/ui/mod.rs @@ -669,14 +669,13 @@ impl TuiApp { // Fallback to old aggregation logic with proper Pending handling let mut has_critical = false; let mut has_warning = false; - let mut has_pending = false; let mut ok_count = 0; for metric in &metrics { match metric.status { Status::Critical => has_critical = true, Status::Warning => has_warning = true, - Status::Pending => has_pending = true, + Status::Pending => {}, // Ignore pending for title bar color Status::Ok => ok_count += 1, Status::Inactive => ok_count += 1, // Treat inactive as OK for aggregation Status::Unknown => {}, // Ignore unknown for aggregation @@ -684,13 +683,11 @@ impl TuiApp { } } - // Priority order: Critical > Warning > Pending > Ok > Unknown + // Priority order: Critical > Warning > Ok > Unknown (no Pending) if has_critical { Status::Critical } else if has_warning { Status::Warning - } else if has_pending { - Status::Pending } else if ok_count > 0 { Status::Ok } else { diff --git a/shared/Cargo.toml b/shared/Cargo.toml index 95d2660..5595ef7 100644 --- a/shared/Cargo.toml +++ b/shared/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "cm-dashboard-shared" -version = "0.1.94" +version = "0.1.95" edition = "2021" [dependencies]