cm/cm-dashboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 266 Wiki Activity

Simplify service recovery notification logic

Browse Source 
- Remove bloated last_meaningful_status tracking
- Treat any Unknown→Ok transition as recovery
- Reduce JSON persistence to only metric_statuses and metric_details
- Eliminate unnecessary status history complexity
This commit is contained in:
Christoffer Martinsson 2025-10-20 19:31:13 +02:00
parent 00a8ed3da2
commit 049ac53629
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
agent/src/notifications/mod.rs
View File

@ -73,6 +73,7 @@ impl NotificationManager {
.copied() .copied()
.unwrap_or(Status::Unknown); .unwrap_or(Status::Unknown);
// Check if status actually changed // Check if status actually changed
if old_status != new_status { if old_status != new_status {
// Update stored status only on change // Update stored status only on change
@ -114,7 +115,7 @@ impl NotificationManager {
// Only notify on transitions to warning/critical, or recovery to ok // Only notify on transitions to warning/critical, or recovery to ok
let should_send = match (status_change.old_status, status_change.new_status) { let should_send = match (status_change.old_status, status_change.new_status) {
(_, Status::Warning) | (_, Status::Critical) => true, (_, Status::Warning) | (_, Status::Critical) => true,
(Status::Warning | Status::Critical, Status::Ok) => true, (Status::Warning | Status::Critical | Status::Unknown, Status::Ok) => true,
_ => false, _ => false,
}; };
@ -136,8 +137,9 @@ impl NotificationManager {
status_change.details = Some(self.format_metric_details(metric)); status_change.details = Some(self.format_metric_details(metric));
// For recovery notifications, include original problem details // For recovery notifications, include original problem details
if status_change.new_status == Status::Ok && let is_recovery = status_change.new_status == Status::Ok;
(status_change.old_status == Status::Warning || status_change.old_status == Status::Critical) {
if is_recovery {
if let Some(old_details) = self.metric_details.get(&status_change.metric_name) { if let Some(old_details) = self.metric_details.get(&status_change.metric_name) {
status_change.details = Some(format!( status_change.details = Some(format!(
"Recovered from: {}\nCurrent status: {}", "Recovered from: {}\nCurrent status: {}",